Bugzilla – Bug 12835
Text Entry - vertical bar assets not tiling correctly
Last modified: 2009-09-08 09:13:02 UTC
The vertical bar appears to have two overlapping assets: 1. Tall background asset 2. center middle asset Number 2 is overlapping the background creating a harsh box around the selected character. The tiling should be seamless. It is most noticeable on the left an right edges along the shadow.
Created attachment 5489 [details] comparison with current textinput ref screen On the left is the current textinput ref screen, on the right is what I've done to get as close as possible to the ref screen. What I've done: - made the textinput horizontal bar the correct height - tweaked the y offset of the selected char to center vertically inside the bar as good as currently possible. What I haven't done: - the spacing of the chars in the vertical bar in the ref screen doesn't work as you scroll down further in the alphabet (e.g., the g ends up bleeding into the horizontal bar when it's just above the selected character). By having that a bit larger (25px), it works better throughout.
Created attachment 5490 [details] comparison of charHeight of 25px v. 20px 25px is on the left, 20px is on the right. 25px is how I currently have it (see first attachment), 20px will achieve tighter spacing at the expense of things looking broken when chars like g show up in the vertical wheel above the selected char. Noah, opinion?
Letters should never be jammed together like the example on the right. If you make the text bigger the baseline spacing should also increase. The one on the left looks ok to me.
Agreed. Characters should never overlap. The ref. screen uses a 22px leading (spacing btwn letters) for 24px text ht. Can you please post an example using the spec. spacing?
r6687 changes the leading to 24px