Bug 12829 - Changes in Extension Downloader doesn't take effect
: Changes in Extension Downloader doesn't take effect
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Plugins
: 7.4.0
: PC Other
: -- normal (vote)
: 7.4.0
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-13 01:48 UTC by Erland Isaksson
Modified: 2009-10-05 14:27 UTC (History)
1 user (show)

See Also:
Category: Bug


Attachments
server.log (25.14 KB, text/x-log)
2009-07-13 01:48 UTC, Erland Isaksson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Erland Isaksson 2009-07-13 01:48:59 UTC
Created attachment 5453 [details]
server.log

There seems to be some problem with Extension Downloader so changes in it doesn't take effect. I'm using svn 27512 of the SQLite branch.

I previously had similar problem when installing the plugins, it took three or four tries before my changes finally survived a restart.

The attached server log contains the following events:
10:32:12: Squeezebox Server was manually started
10:32:35: I entered the Plugins page 
10:33:12: I unchecked the Dynamic Playlist plugin and hit save
10:33:23: I hit Ctrl+C to shutdown Squeezebox Server
10:33:28: I started Squeezebox Server again manually

As you can see, the Dynamic Playlist plugin is still there after the restart. I get the same problem if I use the link in the web interface instead of Ctrl+C to shutdown the server.
Comment 1 Adrian Smith 2009-07-13 13:29:30 UTC
I'm struggling to reproduce, could you enable server.plugins debugging too - this should show the action at startup which is where the uninstall should happen.  It may be best to set this to debug and persist this as a logging setting so that you always record what the server does at starup for plugins.

What platform is this on?
Comment 2 Adrian Smith 2009-07-13 14:29:28 UTC
Erland - please try change 27522.

The reason it appeared random was that calling useImporter during pluginShutdown was causing the server to crash without saving the prefs file.  So if you clicked the button to restart less than 10 seconds after you selected a new plugin, then the pref change would not be saved and the server would restart in the old state.

Please confirm and then we can close the bug.
Comment 3 Erland Isaksson 2009-07-13 16:34:59 UTC
(In reply to comment #2)
> Erland - please try change 27522.
> 

That was it, now it works correctly.
Comment 4 James Richardson 2009-08-01 10:19:40 UTC
Marking as fixed based on change 27522 & comment 3
Comment 5 James Richardson 2009-10-05 14:27:05 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.