Bugzilla – Bug 12820
Sound effects don't sound right when playing non-44.1k files
Last modified: 2009-10-05 14:30:36 UTC
Using firmware r6526, Baby's sound effects sound when pressing keys sound messed up after I start playing an MP3 track. The issue goes away when I start playing a FLAC track.
can you define "messed up" a bit more?
Mickey, what sample rate is the mp3 track where the sound is messed up? I think it's probably not a 44.1k track? So the difference here is the sample rate, not the format.
Created attachment 5462 [details] Sample MP3 track This track exhibited the problem first time I played it. Probably 48KHz sample rate.
This won't make it this week, probably 1-2 days to fix.
Reset priority before triage.
How common are the non 44.1k tracks? If not common and the sounds are not too bad, change to P2. How do you fix this? Will the sound be OK as soon as the track ends? Is it OK on Pandora and other internet radio?
I haven't heard this pop in awhile. I just checked it with MP r6894, and I didn't hear it. I don't know what changed, so should I just close this as fixed?
Common for radio stations. This makes the product appear unfinished it needs fixing.
The track Mickey posted crashes my baby currently, same bug or new one?
well, crashed one time, played nothing and muted all audio (buttons too) the next (and then crashed on the next switch to a new track via play button).
Hmm, different bug. Brandon we should probably discuss this via phone or IM.
*** Bug 13261 has been marked as a duplicate of this bug. ***
Would one possible solution to this be to have the Baby sound effects resampled for all audio playback rates (22050/24000/44100/48000/88200/96000), store them in firmware, and simply select the right one?
I have it working with the speex resampler (http://www.speex.org/). This has a modified BSD licence. We simply need to ensure that the appropriate acknowledgement is included - I'm not sure where to do that. Just finishing off testing different quality levels - the most basic is not good enough - and getting it integrated in the build. Should we build and link this code for all platforms (there is not that much of it) or just for those that need it (currently: Baby, desktop)? In any case the actual resampling will only happen on platforms and in circumstances where it is needed. Should I bother to cut down the code in the resampling module to include only the algorithms we actually use or just leave them all in?
I'm working with lawyers to review our documentation obligations for open source usage. I've added this to the list of items we're using and need to handle properly.
(In reply to comment #14) > I have it working with the speex resampler (http://www.speex.org/). This has a > modified BSD licence. We simply need to ensure that the appropriate > acknowledgement is included - I'm not sure where to do that. I'll work with Mickey on that. > Just finishing off testing different quality levels - the most basic is not > good enough - and getting it integrated in the build. Great. > Should we build and link this code for all platforms (there is not that much of > it) or just for those that need it (currently: Baby, desktop)? In any case the > actual resampling will only happen on platforms and in circumstances where it > is needed. Yes, include it for all platforms. > Should I bother to cut down the code in the resampling module to include only > the algorithms we actually use or just leave them all in? Hopefully gcc will do that for us?
> > Should I bother to cut down the code in the resampling module to include only > > the algorithms we actually use or just leave them all in? > > Hopefully gcc will do that for us? No, they are all in a single compilation unit. But I would not worry that much - we have plenty of other unused code around. We can just remember that there is probably the opportunity so shave a few kB off here f we need to sometime.
== Auto-comment from SVN commit #7508 to the jive repo by ayoung == == https://svn.slimdevices.com/jive?view=revision&revision=7508 == Fixed bug 12820: Sound effects don't sound right when playing non-44.1k files Resample effects when effects sample-rate (always 44100) does not match output sample rate for effects output device. Add speex resampler for this work - using quality level 2.
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server! * SqueezeCenter: 28672 * Squeezebox 2 and 3: 130 * Transporter: 80 * Receiver: 65 * Boom: 50 * Controller: 7790 * Radio: 7790 Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.