Bug 12789 - Known bad memory alloc in kernel. Please fix
: Known bad memory alloc in kernel. Please fix
Status: RESOLVED FIXED
Product: SB Radio
Classification: Unclassified
Component: OS/Bootloader
: Include FW version in comment
: PC Other
: P2 normal (vote)
: MPQ
Assigned To: Richard Titmuss
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-10 22:45 UTC by Caleb Crome
Modified: 2009-09-08 09:30 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Caleb Crome 2009-07-10 22:45:45 UTC
Richard, I implemented per-board msp430 loads in r6518.  finally got all the files right in r6521.


in msp430_programmer.c I did what's below.  I know it's wrong, but I don't know how to manage memory in the kernel, so will you fix that for me? 

Also, I added redboot-0003.bin to the build, along with msp430-0001.txt, msp430-0002.txt, msp430-0003.txt.

If that's a problem, let me know.

// FIXME: TODO:
// Richard Help:  I know this is terrible!  I don't know how to do it right though.
char msp430_txt[20];
void msp430_programmer_upgrade(struct i2c_client *client)
{
	sprintf(msp430_txt, "msp430-%04d.txt", system_rev);
	printk("Attempting to load MSP with file %s\n", msp430_txt);
	request_firmware_nowait(THIS_MODULE, FW_ACTION_HOTPLUG,
				msp430_txt, &client->dev,
				client, msp430_programmer_firmware);
}
Comment 1 Richard Titmuss 2009-07-11 06:32:35 UTC
Removed redboot-0003.bin in r6522, it's not needed unless we rev the bootloader.
Comment 2 Richard Titmuss 2009-07-11 07:09:20 UTC
Fixed in r6523.