Bugzilla – Bug 12789
Known bad memory alloc in kernel. Please fix
Last modified: 2009-09-08 09:30:29 UTC
Richard, I implemented per-board msp430 loads in r6518. finally got all the files right in r6521. in msp430_programmer.c I did what's below. I know it's wrong, but I don't know how to manage memory in the kernel, so will you fix that for me? Also, I added redboot-0003.bin to the build, along with msp430-0001.txt, msp430-0002.txt, msp430-0003.txt. If that's a problem, let me know. // FIXME: TODO: // Richard Help: I know this is terrible! I don't know how to do it right though. char msp430_txt[20]; void msp430_programmer_upgrade(struct i2c_client *client) { sprintf(msp430_txt, "msp430-%04d.txt", system_rev); printk("Attempting to load MSP with file %s\n", msp430_txt); request_firmware_nowait(THIS_MODULE, FW_ACTION_HOTPLUG, msp430_txt, &client->dev, client, msp430_programmer_firmware); }
Removed redboot-0003.bin in r6522, it's not needed unless we rev the bootloader.
Fixed in r6523.