Bug 12786 - Selecting a Network, then backing out and re-selecting will cause network errors
: Selecting a Network, then backing out and re-selecting will cause network errors
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Networking
: unspecified
: PC Windows XP
: P1 normal (vote)
: 7.4.0
Assigned To: Felix Mueller
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-10 16:17 UTC by James Richardson
Modified: 2009-10-05 14:33 UTC (History)
1 user (show)

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Richardson 2009-07-10 16:17:05 UTC
Factory Reset
Follow setup wizard
Select Ethernet
connect and get to 
back out to network selection
select Ethernet again
notice that baby will fail to connect and appear locked up

Same thin happens for Wireless OR if you select one and back out to select the other.

Factory Reset corrects the issue
--------------------------------
Comment 1 Felix Mueller 2009-07-15 07:56:38 UTC
Tom: It seems to me that when screen 'Squeezebox Account' is reached during setup some state gets stored which then prevents the logic from connecting to SN when a user changes its mind, backs out and reselects 'ethernet' as connection type.

I've checked and the underlying network gets an ip again just fine and can do pings. I am wondering if you have an idea what would need to be 'unstored' when a user backs out to fix this issue.

=========================================
--First attempt, just after factory reset:


Jan  1 00:02:17 udhcpc[1037]: Sending discover...
Jan  1 00:02:18 udhcpc[1037]: Sending select for 192.168.144.72...
Jan  1 00:02:18 udhcpc[1037]: Lease of 192.168.144.72 obtained, lease time 86400
Jan  1 00:02:18 root: udhcpc_action eth0 bound ip=192.168.144.72
Jan  1 00:02:19 squeezeplay: INFO   net.comet - Comet.lua:240 Comet {mysqueezebox.com}: Got networkConnected event, will try to r
econnect
Jan  1 00:02:19 squeezeplay: INFO   squeezebox.server - SlimServer.lua:661 disconnected mysqueezebox.com idleTimeoutTriggered: ni
l
Jan  1 00:02:20 squeezeplay: INFO   squeezebox.server - SlimServer.lua:640 connected mysqueezebox.com
Jan  1 00:02:21 squeezeplay: INFO   squeezebox.server - SlimServer.lua:289 mysqueezebox.com firmware=http://update.squeezenetwork
.com/update/firmware/.7.4/baby_7.4_r6526.bin force=false
Jan  1 00:02:21 squeezeplay: INFO   applet.SlimMenus - SlimMenusApplet.lua:143 ***linked SN     SlimServer {mysqueezebox.com}
Jan  1 00:02:21 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:187 step6
Jan  1 00:02:21 squeezeplay: INFO   applet.SlimDiscovery - SlimDiscoveryApplet.lua:560 selected Squeezebox Radio
Jan  1 00:02:21 squeezeplay: INFO   applet.SlimMenus - SlimMenusApplet.lua:791 SlimMenusApplet:notify_playerCurrent(LocalPlayer {
Squeezebox Radio})
Jan  1 00:02:21 squeezeplay: INFO   applet.SlimMenus - SlimMenusApplet.lua:817 player changed from:false to LocalPlayer {Squeezeb
ox Radio} but server not yet present
Jan  1 00:02:21 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:498 network setup complete
Jan  1 00:02:21 squeezeplay: INFO   squeezeplay.applets - AppletManager.lua:694 store settings: SetupWelcome
Jan  1 00:02:21 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:263 Waiting to connect to SqueezeNetwork and fin
d any compatible SCs
Jan  1 00:02:22 squeezeplay: WARN   applet.SlimMenus - SlimMenusApplet.lua:954 MERGE SN menus
Jan  1 00:02:22 squeezeplay: INFO   applet.SlimMenus - SlimMenusApplet.lua:331 _menuSink() SlimServer {mysqueezebox.com}
Jan  1 00:02:22 squeezeplay: INFO   applet.SlimMenus - SlimMenusApplet.lua:479 Eliminated myMusic node from server, since now han
dled locally
Jan  1 00:02:22 squeezeplay: WARN   applet.SlimMenus - SlimMenusApplet.lua:954 MERGE SN menus
Jan  1 00:02:22 squeezeplay: INFO   applet.SlimMenus - SlimMenusApplet.lua:331 _menuSink() SlimServer {mysqueezebox.com}
Jan  1 00:02:22 squeezeplay: INFO   applet.SlimMenus - SlimMenusApplet.lua:479 Eliminated myMusic node from server, since now han
dled locally
Jan  1 00:02:22 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:413 step8
Jan  1 00:02:22 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:423 squeezenetwork pin=957D5 url=http://update.s
queezenetwork.com/update/firmware/.7.4/baby_7.4_r6526.bin
Jan  1 00:02:22 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:455 registration on SN


=============================================================
-- Second attempt (after going back and reselecting ethernet)


Jan  1 00:05:34 udhcpc[1289]: Sending discover...
Jan  1 00:05:34 udhcpc[1289]: Sending select for 192.168.144.72...
Jan  1 00:05:34 udhcpc[1289]: Lease of 192.168.144.72 obtained, lease time 86400
Jan  1 00:05:34 root: udhcpc_action eth0 bound ip=192.168.144.72
Jan  1 00:05:35 squeezeplay: INFO   squeezebox.server - SlimServer.lua:661 disconnected mysqueezebox.com idleTimeoutTriggered: ni
l
Jan  1 00:05:35 squeezeplay: INFO   net.comet - Comet.lua:240 Comet {mysqueezebox.com}: Got networkConnected event, will try to r
econnect
Jan  1 00:05:35 squeezeplay: INFO   squeezebox.server - SlimServer.lua:661 disconnected mysqueezebox.com idleTimeoutTriggered: ni
l
Jan  1 00:05:36 squeezeplay: INFO   squeezebox.server - SlimServer.lua:640 connected mysqueezebox.com
Jan  1 00:05:37 squeezeplay: INFO   squeezebox.server - SlimServer.lua:289 mysqueezebox.com firmware=http://update.squeezenetwork
.com/update/firmware/.7.4/baby_7.4_r6526.bin force=false
Jan  1 00:05:37 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:187 step6
Jan  1 00:05:37 squeezeplay: INFO   applet.SlimDiscovery - SlimDiscoveryApplet.lua:560 selected Squeezebox Radio
Jan  1 00:05:37 squeezeplay: INFO   applet.SlimMenus - SlimMenusApplet.lua:791 SlimMenusApplet:notify_playerCurrent(LocalPlayer {
Squeezebox Radio})
Jan  1 00:05:37 squeezeplay: INFO   applet.SlimMenus - SlimMenusApplet.lua:817 player changed from:false to LocalPlayer {Squeezeb
ox Radio} but server not yet present
Jan  1 00:05:37 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:498 network setup complete
Jan  1 00:05:37 squeezeplay: INFO   squeezeplay.applets - AppletManager.lua:694 store settings: SetupWelcome
Jan  1 00:05:37 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:263 Waiting to connect to SqueezeNetwork and fin
d any compatible SCs
Jan  1 00:05:38 squeezeplay: WARN   applet.SlimMenus - SlimMenusApplet.lua:954 MERGE SN menus
Jan  1 00:05:38 squeezeplay: INFO   applet.SlimMenus - SlimMenusApplet.lua:331 _menuSink() SlimServer {mysqueezebox.com}
Jan  1 00:05:38 squeezeplay: INFO   applet.SlimMenus - SlimMenusApplet.lua:479 Eliminated myMusic node from server, since now han
dled locally
Jan  1 00:05:38 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:413 step8
Jan  1 00:05:38 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:423 squeezenetwork pin=957D5 url=http://update.s
queezenetwork.com/update/firmware/.7.4/baby_7.4_r6526.bin
Jan  1 00:05:39 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:413 step8
Jan  1 00:05:39 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:423 squeezenetwork pin=957D5 url=http://update.s
queezenetwork.com/update/firmware/.7.4/baby_7.4_r6526.bin
Comment 2 Wadzinski Tom 2009-07-15 08:20:13 UTC
James can you confirm: Is this post-MP? In the real world the user will be prompted for an update prior to 'Squeezebox Account'.

If so then let's target it for 7.4, since I don't think it's a showstopper for CAT/CXR
Comment 3 James Richardson 2009-07-15 13:29:54 UTC
This appears to be post-mp.

The only time I have an issue, is when i'm fully connected, and attempt to switch to a different network.

I.E.  Connect via wireless, connect to AP, connect to SN.  Goto Network Setting and choose another network (different AP or wired) get connected to the net, fail to connect to SN.

Infinite spinney 'Connecting to MySB.com'
==================
If I do the same above BEFORE associating with SN (I.E. the account setup page) then I can select a new network just fine.
Comment 4 Richard Titmuss 2009-07-27 01:14:12 UTC
Reset priority before triage.
Comment 5 Felix Mueller 2009-08-04 07:03:12 UTC
Fixed in r6901.
Comment 6 Felix Mueller 2009-08-04 07:42:39 UTC
Seem like there is a second issue which still needs to be fixed.

Tom: My observation in comment #1 is still valid. Any ideas as why it would fail to reconnect to mysqueezebox.com after a network change?

Using a serial console I can confirm that even after the network change (i.e. from wireless to ethernet) mysqueezebox.com can be pinged just fine.

This is repeating over and over in the log:

Jan  1 00:12:28 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:345 SN now seen
Jan  1 00:12:29 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:414 step8
Jan  1 00:12:29 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:424 squeezenetwork pin=43FAE url
=http://update.squeezenetwork.com/update/firmware/.7.4/baby_7.4_r6896.bin
Jan  1 00:12:29 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:297 Can't find any SC or connect
 to SqueezeNetwork after 463 seconds
Jan  1 00:12:29 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:307 _squeezenetworkFailed
Jan  1 00:12:29 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:311 Can't connect to SqueezeNetw
ork: baby.squeezenetwork.com
Jan  1 00:12:30 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:345 SN now seen
Jan  1 00:12:30 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:414 step8
Jan  1 00:12:30 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:424 squeezenetwork pin=43FAE url
=http://update.squeezenetwork.com/update/firmware/.7.4/baby_7.4_r6896.bin
Jan  1 00:12:30 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:297 Can't find any SC or connect
 to SqueezeNetwork after 464 seconds
Jan  1 00:12:30 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:307 _squeezenetworkFailed
Jan  1 00:12:30 squeezeplay: INFO   applet.SetupWelcome - SetupWelcomeApplet.lua:311 Can't connect to SqueezeNetw
ork: baby.squeezenetwork.com
Comment 7 Wadzinski Tom 2009-08-04 11:09:49 UTC
From what I can see, in the case where 1) you back after a network connection, and b) a FW upgrade is not needed (which is the case reading the output in comment #6), the following path is used:

step8(), which calls _registerRequest(), but then self.registerRequest has already been set after the first connection completed, so step8 is basically ignored, which the causes the Popup to stay up and eventually timeout.

So the registration state needs to be cleared. I'm not sure exactly the best way to do that to avoid potential race conditions.
Comment 8 Wadzinski Tom 2009-08-04 11:12:02 UTC
Note: whatever we fix here should be ported to the other SetupWelcomeApplets.
Comment 9 Felix Mueller 2009-08-06 22:24:45 UTC
Changed Hours Left from 0.0 to 8.0 as additional work is needed to fix this bug. I am not sure this is the correct thing to do, but changing Orig. Est. seems wrong.
Comment 10 SVN Bot 2009-08-28 22:58:05 UTC
 == Auto-comment from SVN commit #7318 to the jive repo by felix ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7318 ==

Bug: 12786 
Description: Selecting a Network, then backing out and re-selecting will cause network errors
Comment 11 SVN Bot 2009-08-28 22:58:37 UTC
 == Auto-comment from SVN commit #7319 to the jive repo by felix ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7319 ==

Bug: 12786
Description: Selecting a Network, then backing out and re-selecting will cause network errors
Comment 12 SVN Bot 2009-08-28 22:58:54 UTC
 == Auto-comment from SVN commit #7320 to the jive repo by felix ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7320 ==

Bug: 12786
Description: Selecting a Network, then backing out and re-selecting will cause network errors
Comment 13 Felix Mueller 2009-08-28 23:08:17 UTC
Fixed in r7320.
Comment 14 James Richardson 2009-10-05 14:33:21 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.