Bug 12762 – consider a window style that explicitly does not include icons

Bug 12762 - consider a window style that explicitly does not include icons

Summary:

consider a window style that explicitly does not include icons

Status:	CLOSED FIXED

Product:	SB Radio
Classification:	Unclassified
Component:	Menus
Version:	Include FW version in comment
Platform:	PC Other

Importance:	P2 normal (vote)
Target Milestone:	CAT
Assigned To:	Ben Klaas

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-07-09 13:22 UTC by Ben Klaas
Modified:	2010-05-27 14:46 UTC (History)
CC List:	5 users (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ben Klaas 2009-07-09 13:22:56 UTC

There are cases where a menu, even if some of the items have an icon or iconStyle defined, should not present any icons. This is a post-MP thing to sort out, but I think we need each skin to have a window style that explicitly does not have icons.

Previously this was text_list, but now text_list also supports icons. This manifested itself in setup where an icon would be delivered for help but not the other items in the menu, which was not desired. This was worked around by just removing the iconStyle from the help item, but it's not a complete solution.

It could be what's required is that text_list becomes the icon-free style, and icon_list is exactly text_list but with icon support. This will require a fairly thorough audit through windows in squeezeplay to determine whether text_list or icon_list were chosen correctly.

Comment 1 Weldon Matt 2009-07-09 14:00:12 UTC

Is this simply a user setting you think we need?

I'm not sure if I understand what's driving this.

Comment 2 Ben Klaas 2009-07-14 10:10:04 UTC

Weldon- no, that's not it. I want to avoid the case of a menu that has icons on some items and not others. If we had a window style that explicitly left out the icon, there is a route to easily avoiding that situation. An example would be Settings->Advanced, which should never show an icon on any menu item. Another example would be setup menus, which I think we've dumped icons on all menus.

Comment 3 Weldon Matt 2009-07-14 10:25:33 UTC

Yeah Ben, I just misunderstood.  Great idea...

Comment 4 Ben Klaas 2009-07-21 21:46:57 UTC

fixed in r6733 by adding new window style in skins called 'text_only'. This style explicitly excludes icons from menu items and is now used for settings->advanced and all applicable settings/adv settings submenus

Comment 5 James Richardson 2009-10-06 09:22:04 UTC

This bug has been fixed in the latest release of MySqueezebox.com (formally
known as SqueezeNetwork)!

If you are still experiencing this problem, feel free to reopen the bug with
your new comments and we'll have another look.

Comment 6 Chris Owens 2010-05-27 14:46:33 UTC

These bugs have all been marked resolved and belong to a component which is being removed.  Therefore they have been moved to the most applicable of the new components.