Bug 12760 - Feature Request: Alarm Timeout behavior
: Feature Request: Alarm Timeout behavior
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Alarm
: unspecified
: All All
: P1 normal with 1 vote (vote)
: 7.4.x
Assigned To: Ben Klaas
:
Depends on: 14578
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-09 11:43 UTC by Julius Dauz
Modified: 2009-12-21 14:25 UTC (History)
4 users (show)

See Also:
Category: Feature


Attachments
Return to previous power state (988 bytes, patch)
2009-09-10 14:24 UTC, KDF
Details | Diff
fix a typo (1004 bytes, patch)
2009-09-10 15:54 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julius Dauz 2009-07-09 11:43:54 UTC
Currently, when an alarm activates then goes into timeout, the player stays in the ON state. 

This enhancement is to make a change so that when the alarm times out, it then goes into Idle mode.
Comment 1 Chris Owens 2009-07-13 09:52:01 UTC
Is this from a customer, Julius?
Comment 2 Julius Dauz 2009-07-14 14:57:10 UTC
Adding comment for customer:

As an enhancement, I suggest that users be given settings with the option to switch Squeezebox to power off or pause after the alarm cycle times out. I assume most people power it off manually and some may use the sleep mode to let the unit time out and power off. The enhancement would have the same result.  A new setting would enable the unit to power off instead of going into idle or pause.
Comment 3 James Richardson 2009-07-22 09:00:48 UTC
Max: Does this sound reasonable and easy to do?
Comment 4 Chris Tashjian 2009-08-07 05:51:59 UTC
Doing this would negate the need for Bug 9569, correct?  I'm all for one of these fixes getting into 7.4
Comment 5 Ben Klaas 2009-08-26 07:50:25 UTC
this is an administrative shuffle on priority fields to help make better judgment on the top end of the priority list. P4->P5, P3->P4, and P2->P3.
Comment 6 KDF 2009-09-10 14:24:23 UTC
Created attachment 5820 [details]
Return to previous power state

This patch stores the previous power state and restores it when the alarm is stopped.  This works in much the same way as the pre-alarm volume is saved and restored.

If a pref is absolutely required for this, it's easy to add a per-alarm pref to go along with it.  Seems sensible just to leave it as automatic since that is what is done with volume.
Comment 7 KDF 2009-09-10 15:54:33 UTC
Created attachment 5829 [details]
fix a typo
Comment 8 Chris Owens 2009-09-10 15:56:53 UTC
Pat, I don't have a clear feeling about whether you think a patch like this should be reviewed and committed at this time.  It is for an alarm-related bug, which would be good to have fixed for ba... I mean Squeezebox Radio.
Comment 9 James Richardson 2009-10-06 10:16:29 UTC
Ben: can you review the attached patch?  maybe implement for 7.4.1
Comment 10 Ben Klaas 2009-12-14 15:19:39 UTC
Finally getting back to 7.4.x after clearing my 7.5.0 P1 list. This seems simple and so I'll make it a P1.
Comment 11 SVN Bot 2009-12-21 14:25:57 UTC
 == Auto-comment from SVN commit #29665 to the slim repo by bklaas ==
 == https://svn.slimdevices.com/slim?view=revision&revision=29665 ==

Fixed Bug: 12760
Fixed Bug: 9569
Desription: Patch from KDF (better late than never). 
Grab power condition before alarm so we can return later on a timeout.