Bug 12755 - missing icons in settings menu
: missing icons in settings menu
Status: CLOSED FIXED
Product: SB Radio
Classification: Unclassified
Component: Settings
: Include FW version in comment
: PC Other
: P1 normal (vote)
: CAT
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-09 07:24 UTC by Ben Klaas
Modified: 2009-10-06 09:21 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
missing icons in settings menu (48.27 KB, image/png)
2009-07-09 07:24 UTC, Ben Klaas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2009-07-09 07:24:18 UTC
Created attachment 5437 [details]
missing icons in settings menu

in the top level settings menu, I see two items that do not have icons-

"Name" - this was promoted from Advanced Settings to Settings with the recent (last night) reorg that Tom did per Weldon's org spec.

"Select Skin" - I'm not 100% sure this is going to appear on device, but it does appear on desktop. My recommendation is to move it into the Screen submenu, as it deals with how things are rendered on the screen. If we do that, we don't need an icon. Weldon, what say you?
Comment 1 ndijulio 2009-07-09 09:37:05 UTC
FYI the entire icon library will have a large update this Friday, including the remaining setting icons with the latest org. spec. 

Let me know if we need to add Select Skin ASAP.
Comment 2 Weldon Matt 2009-07-09 09:38:35 UTC
Yeah...

I have a feeling, with the constant minor controversies around font sizes etc,
that users are going to need some kind of "text size" setting (probably
eventually supported with the "size" button on the classic remote).  I don't
think that needs to literally translate into the "skin" per se, but I held off
bugging you about this until the skins were completed.
Comment 3 Ben Klaas 2009-07-09 09:39:07 UTC
Weldon, what do you think about moving Select Skin into the Screen submenu?
Comment 4 Weldon Matt 2009-07-09 09:39:57 UTC
FYI the "text size" setting is already listed in the wiki as part of the
settings menu redesign:

http://embargo.wiki.slimdevices.com/index.php/Fab4_Settings

Those settings are what we should be designing for re: icons.
Comment 5 Weldon Matt 2009-07-13 21:04:13 UTC
All the icons seem to be present now as of r6537 (with the latest SC), except for "Squeezebox Name."  Noah, do we have an asset for this?

FYI this is targeted for CXR...
Comment 6 ndijulio 2009-07-15 10:07:22 UTC
Matt- "Squeezebox Name" = Player Name correct?  What is the final nomenclature?

There is an icon for changing the player name in the directory, however, it is labeled > icon_settings_name.png

Ben-please pull in this asset if not done so already.

FYI we did not create a "Select Skin" icon.  Please let me know if we need to do so.
Comment 7 Weldon Matt 2009-07-15 14:21:12 UTC
We don't need a "select skin" icon.  If this feature survives it will be a submenu under "screen settings." (I would like to see if we can make this one-and-the-same with "text size," but in terms of the icon it's moot - either way, no icon needed)
Comment 8 ndijulio 2009-07-15 14:30:03 UTC
Ben- reassigning to you. Please pull in the updated assets.
Comment 9 Ben Klaas 2009-07-16 06:32:52 UTC
fixed in r6594
Comment 10 Ben Klaas 2009-07-16 07:13:35 UTC
Weldon- on comment #7, it's probably never going to be synonymous with text size, as desktop squeezeplay will have the ability of loading skins of different resolutions (i.e., baby, controller, fab4, and *gasp* something actually optimized for the desktop). But I agree it should go in screen settings, and I've already placed it there. Ergo, no icon issue in the settings menu with that one now.
Comment 11 James Richardson 2009-10-06 09:21:56 UTC
This bug has been fixed in the latest release of MySqueezebox.com (formally
known as SqueezeNetwork)!

If you are still experiencing this problem, feel free to reopen the bug with
your new comments and we'll have another look.