Bugzilla – Bug 12733
Use dynamic player brightness string
Last modified: 2009-10-05 14:32:08 UTC
From UI spec: http://embargo.wiki.slimdevices.com/index.php/Fab4_Settings “Brightness” (if device is being used as a controller, add submenu “Controller Brightness” / “[Player Name] Brightness”)
Weldon, would you mind discussing this one a bit further? I have a proposal-- changing a remote player's brightness with a Fab4 is such a corner case that it's not worth confusing the user that wants to dim the display they are looking at...I'm not sure we should deliver anything but local brightness control on any SP-based device. Thoughts?
I agree with Ben, let's optimize for the overwhelming common case here.
Bah, I've come up with a use case that seems legitimate for keeping the Player Display submenu. This menu includes Text Size and Standby Text Size in addition to Player Brightness. SBC users should feel like they can dump their IR remote in favor of the SBC, and for SB Classic and other ip3K players, the text size and brightness buttons from the IR buttons could be missed. New proposal: move the "Player Display" submenu to advanced settings. The item will only show up when connected to an IP3K player. If someone wants it more available they can put it on the home menu, otherwise it's not muddying the main Settings->Brightness menu, which is for controlling the brightness of the display the user is physically viewing.
OK, now I'm confused. There is no "Player Display" menu I'm aware of, and "brightness" is in a different menu from "text size" (which is supposed to be in the "screen" submenu).
Sorry, that must be remaining cruft from prior organization. I thought Tom had done the big rearrangement, but I guess that's not the case here. I'm not talking about Text Size of the SP device (Fab4 or otherwise), I'm talking about adjusting the Text Size of an IP3K player. The use case is SBC + Ip3K player like Classic or Boom. why don't we chat on this in campfire or by phone...
that is, the Text Size you have in the wiki at Screen->Text Size is for a replacement of Select Skin...not the same as what I'm discussing re: remote player settings.
Created attachment 5514 [details] player display settings submenu when connected to a boom These items fulfill what's currently available as buttons on the classic IR remote. None of this shows up when connected to anything but a SliMp3/SB1/SB2/SB Classic/Boom. to summarize: I think Settings->Brightness should be reserved for the local device I think these Player Display items have a place, but putting them in advanced settings seems like a reasonable spot for them. the alternative could be to remove them entirely, but it seems like a regression given the IR remote has dedicated buttons for them. A user that replaces an IR remote with a $300 SBC should probably have 100% of the functionality of the IR remote...
Ben, I trust your judgement on this one (OMG! :-), your solution sounds reasonable and those points all make sense to me. So I think we're saying: - Settings->Brightness should be reserved for the local device - Player Display goes under advanced settings
Yes, that's exactly it. Since you sounded positive about that idea, I'm going to JFDI
done, r27793 this bug requires no strings, so removing SLT tag
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server! * SqueezeCenter: 28672 * Squeezebox 2 and 3: 130 * Transporter: 80 * Receiver: 65 * Boom: 50 * Controller: 7790 * Radio: 7790 Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.