Bug 1266 - Large Playlists cannot be saved
: Large Playlists cannot be saved
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Playlists
: 6.0.0
: PC Linux (other)
: P2 critical with 1 vote (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-31 12:23 UTC by Theo Bresler
Modified: 2008-08-18 10:54 UTC (History)
0 users

See Also:
Category: ---


Attachments
skip tracks when objectForURL fails on saving playlist (518 bytes, patch)
2005-04-28 21:48 UTC, KDF
Details | Diff
one bit missing (518 bytes, patch)
2005-04-28 21:53 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Theo Bresler 2005-03-31 12:23:19 UTC
When the playlist is very large (in the region of 350+ songs in the list) It is
not possible to save these playlists.  When Saving whith Firefox, a popup screen
: "Document contains no data" is displayed.  In IE, The left frame displayes the
same as when a web page cannot be found.  In both cases the slimserver crashes,
the slimdevice cannot find the server any more and the server has to be started
again.  I have tried to 1. Wipe the cache, 2. Rescan but thye problem persists.
The following is the lines visible in slimserver.log:
2005-03-31 22:05:41.0054 Backtrace:

   frame 0: Slim::DataStores::DBI::DBIStore::objectForUrl
(/usr/local/slimserver//Slim/Web/Pages.pm line 1299)
   frame 1: Slim::Web::Pages::buildPlaylist
(/usr/local/slimserver//Slim/Utils/Scheduler.pm line 95)
   frame 2: Slim::Utils::Scheduler::run_tasks
(/usr/local/slimserver/slimserver.pl line 590)
   frame 3: main::idle (/usr/local/slimserver/slimserver.pl line 549)
   frame 4: main::main (/usr/local/slimserver/slimserver.pl line 1111)

2005-03-31 22:05:41.0066 Null track request!
2005-03-31 22:05:41.0076 Backtrace:

   frame 0: Slim::DataStores::DBI::DBIStore::objectForUrl
(/usr/local/slimserver//Slim/Web/Pages.pm line 1299)
   frame 1: Slim::Web::Pages::buildPlaylist
(/usr/local/slimserver//Slim/Utils/Scheduler.pm line 95)
   frame 2: Slim::Utils::Scheduler::run_tasks
(/usr/local/slimserver/slimserver.pl line 590)
   frame 3: main::idle (/usr/local/slimserver/slimserver.pl line 549)
   frame 4: main::main (/usr/local/slimserver/slimserver.pl line 1111)
Comment 1 KDF 2005-04-28 21:48:37 UTC
Created attachment 470 [details]
skip tracks when objectForURL fails on saving playlist

i tried this myself, and the crash is:
Can't call method "title" on an undefined value at
/mnt/mandrake/usr/local/slimserver/trunk/Slim/Formats/Parse.pm line 601.

clearly a track object is somehow not getting retrieved properly. this patch
simply copies an output and skipping code used in Pages.pm for just the same
kind of problem.
Comment 2 KDF 2005-04-28 21:53:40 UTC
Created attachment 471 [details]
one bit missing

missed changing a var name.
Comment 3 KDF 2005-04-28 22:49:40 UTC
patch committed to 6.1 builds: change 3100
patch committed to 6.0.x builds: change 3101

this should now fix the crash, and report the problem tracks to the log.  please
try a the April 29 build and re-open if there are any further issues.
Comment 4 Chris Owens 2008-03-11 11:28:05 UTC
This bug was marked resolved in Slimserver 6.1, which is several versions ago.  If you're still seeing this bug, please re-open it.  Thanks!