Bug 12536 – Titlebar text should be left justified and centered vertically

Bug 12536 - Titlebar text should be left justified and centered vertically

Summary:

Titlebar text should be left justified and centered vertically

Status:	RESOLVED FIXED

Product:	SB Radio
Classification:	Unclassified
Component:	Settings
Version:	Include FW version in comment
Platform:	All Other

Importance:	-- minor (vote)
Target Milestone:	---
Assigned To:	Ben Klaas

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-06-25 16:32 UTC by ndijulio
Modified:	2009-09-08 09:16 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
screenshot of fix (31.00 KB, image/png) 2009-06-26 18:47 UTC, Ben Klaas	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description ndijulio 2009-06-25 16:32:11 UTC

This is true for Baby/Jive/Fab IR skins unless specified otherwise in current guidelines.

Comment 1 Ben Klaas 2009-06-26 18:47:06 UTC

fixed r6267

Noah, vertical centering is oddly tricky in the skin code. I feel like it should be as easy as just saying align = 'center', but alas it is not. I try to pay special attention to it, but the fact that I have to add a couple pixels of top padding here and there to make things space correctly means the more attentive eyes (re: YOU) on that issue the better. I think the centering looks good here now.

Comment 2 Ben Klaas 2009-06-26 18:47:56 UTC

Created attachment 5374 [details]
screenshot of fix

Comment 3 Ben Klaas 2009-06-26 18:50:16 UTC

speaking of which, I see in that screenshot that the iconbar icons are also not centered vertically. I added some padding and they should look right in r6268