Bug 12518 - Icons for plugins in menus are no longer being displayed.
: Icons for plugins in menus are no longer being displayed.
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: --
: unspecified
: PC Other
: P2 normal (vote)
: 7.4.0
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-24 06:44 UTC by Bryan Alton
Modified: 2009-10-05 14:32 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Alton 2009-06-24 06:44:10 UTC
After upgrade to r6223 - icons in menus are no longer displayed for plugins such as AlienBBC but also SC plugin such as Sound Effects in Extras.
Comment 1 Bryan Alton 2009-06-25 03:23:16 UTC
The missing icons could be associated with this SkinManager.pm error as it seems to happen with each icon fetch.

[09-06-25 11:17:38.4958] Slim::Web::Graphics::processCoverArtRequest (114) this is a transparent png request
[09-06-25 11:17:38.4973] Slim::Web::Graphics::processCoverArtRequest (222) Asking for trackid: notCoverArt - radiosearch at size 40x40
[09-06-25 11:17:38.4981] Slim::Web::Graphics::processCoverArtRequest (316)   got cover art image image/png of 26993 bytes
[09-06-25 11:17:38.5200] Slim::Web::Graphics::processCoverArtRequest (433)   resizing from 336x336 to 40 x 40 using original
[09-06-25 11:17:38.5217] Slim::Web::Graphics::processCoverArtRequest (505) Set alpha for transparent png
[09-06-25 11:17:38.5227] Slim::Web::Graphics::processCoverArtRequest (527) Resampling file for better quality
[09-06-25 11:17:38.5412] Slim::Web::Graphics::processCoverArtRequest (573)   outputting cover art image image/png of 2211 bytes
[09-06-25 11:17:38.5427] Slim::Networking::IO::Select::__ANON__ (125) Error: Select task failed calling Slim::Web::HTTP::processHTTP: Can't call method "context" on an undefined value at /home/repos/slim/7.4sqllite/noweb-sqlite/server/Slim/Web/Template/SkinManager.pm line 264.
; fh=Slim::Web::HTTP::ClientConn=GLOB(0xbc4aad4)

Missing icons occurs with all Plugin such as Mediafly and Classical.com.  Once the icons appeared and another time after a restart some of my plugin icons were on the wrong item.
Comment 2 Bryan Alton 2009-06-25 03:42:00 UTC
If I replace the code for _getSkinDir in Slim/Web/Template/SkinManager.pm by the code for the same routine from Slim/Web/Template/NoWeb.pm - all the icons are displayed correctly.

My version of noweb-sqlite is an SVN copy so this is causing the bug.
Comment 3 Ben Klaas 2009-07-14 13:56:50 UTC
Sorry, I think this bug is improperly assigned. Adding a bug_meeting keyword so this will be discussed at our next bug meeting and assigned appropriately.
Comment 4 Michael Herger 2009-07-21 01:03:07 UTC
Triode mentioned this before. Those icons used by Squeezeplay probably shouldn't be skinned (go through the skinning mechanism). If somebody ever decided to use a different skin they _might_ look wrong on the devices.
Comment 5 Bryan Alton 2009-07-22 00:55:31 UTC
rev 27658 to SkinManager.pm seems to have fixed the problem.
Comment 6 Michael Herger 2009-07-22 01:36:23 UTC
Thanks for the confirmation.
Comment 7 James Richardson 2009-10-05 14:32:35 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.