Bugzilla – Bug 1243
MusicMagic mixes do not play on remote client
Last modified: 2008-08-18 10:54:16 UTC
The 'play now' and 'add to playlist' links do not work correctly when trying to play MusicMagic mixes to a remote client. The playlist count for the client increments by one, but nothing is added to the actual list of tracks playlist for the client. This is on Win2k3 in multiple skins. The links work correctly for hardware players on the same server.
Mixes play fine on Softsqueeze on the same remote client.
just to clarify... you are unable to use 'play now' or 'add to playlist' links from the bottom of a musicmagic mix when sending to a remote http client? if you are using a remote softsqueeze from the same remote computer, these links work? offhand, I can't think of any reason the behaviour would differ for these cases. This is partly the reason I wish to clarify in case I'm misreading. If you can attach more details, that might help. how about d_command and d_playlist log output, which skins are affected (one or several?).
Here's the relevant log excerpt: 2005-03-30 21:04:59.4337 Skipping playlist build - not modified. 2005-03-30 21:05:04.6535 currentPlaylistChangeTime : Wed Mar 30 18:43:28 2005 2005-03-30 21:05:04.6536 currentPlaylistRender : Wed Mar 30 21:03:56 2005 2005-03-30 21:05:04.6536 currentPlaylistRenderSkin : 2005-03-30 21:05:04.6537 currentPlaylistRenderStart: 0 2005-03-30 21:05:04.6537 skinOverride: 2005-03-30 21:05:04.6538 start: 0 2005-03-30 21:05:04.6538 Skipping playlist build - not modified. 2005-03-30 21:05:06.1409 Executing command 193.130.25.241: playlist (playtracks) (listref=musicmagic_mix&path=status_header.html&player=193.130.25.241&url_query =player=193.130.25.241&command=playlist&subcommand=playtracks&listref=musicmagi c_mix&host=merckx:9000&subcommand=playtracks&webroot=/&command=playlist) () () () () () 2005-03-30 21:05:06.1578 Returning array: playlist (playtracks) (listref=musicmagic_mix&path=status_header.html&player=193.130.25.241&url_query =player=193.130.25.241&command=playlist&subcommand=playtracks&listref=musicmagi c_mix&host=merckx:9000&subcommand=playtracks&webroot=/&command=playlist) () () () () () 2005-03-30 21:05:06.4188 currentPlaylistChangeTime : Wed Mar 30 21:05:06 2005 2005-03-30 21:05:06.4189 currentPlaylistRender : Wed Mar 30 21:03:56 2005 2005-03-30 21:05:06.4189 currentPlaylistRenderSkin : 2005-03-30 21:05:06.4190 currentPlaylistRenderStart: 0 2005-03-30 21:05:06.4190 skinOverride: 2005-03-30 21:05:06.4191 start: 0 2005-03-30 21:05:06.4197 Starting playlist build. 2005-03-30 21:05:06.4213 End playlist build. 1 items 2005-03-30 21:05:36.6659 currentPlaylistChangeTime : Wed Mar 30 21:05:06 2005 2005-03-30 21:05:36.6660 currentPlaylistRender : Wed Mar 30 21:05:06 2005 2005-03-30 21:05:36.6661 currentPlaylistRenderSkin : 2005-03-30 21:05:36.6661 currentPlaylistRenderStart: 0 2005-03-30 21:05:36.6662 skinOverride:
kdf, your summary is correct. When using an http stream (same subnet as well as truly remote), the 'play' and 'add to playlist' links do not work. Running softsqueeze on the same client, these links function correctly. I've verified this in Fishbone and Default skins. HTH, Chris
the log entry is the same for both cases? The log you have included here is the http client, correct?
Indeed correct. Log for Softsqueeze: 2005-03-30 22:46:13.0618 Executing command 51:fc:59:b2:79:fa: playlist (playtracks) (listref=musicmagic_mix&path=status_header.html&player=51:fc:59:b2:79:fa&url_qu ery=player=51%3Afc%3A59%3Ab2%3A79% 3Afa&command=playlist&subcommand=playtracks&listref=musicmagic_mix&host=merckx: 9000&subcommand=playtracks&webroot=/&command=playlist) () () () () () 2005-03-30 22:46:13.4547 Returning array: playlist (playtracks) (listref=musicmagic_mix&path=status_header.html&player=51:fc:59:b2:79:fa&url_qu ery=player=51%3Afc%3A59%3Ab2%3A79% 3Afa&command=playlist&subcommand=playtracks&listref=musicmagic_mix&host=merckx: 9000&subcommand=playtracks&webroot=/&command=playlist) () () () () () 2005-03-30 22:46:14.0069 Starting playlist build. 2005-03-30 22:46:14.3368 End playlist build. 12 items
This may be a problem. This bug also affects search results (add all links). These are created using a client parameter, which is stored as part of the current modeStack. Given that HTTP clients do not have a modestack, they dont seem to store params the way that these types of lists require. cc'ing moser for input on this one.
$client->param() will return undef if $client->modeParameterStack[-1] is undefined. This will always be the case for HTTP clients currently, since we never call a Slim::Buttons::Common::setMode on them. So, I would recommend initializing modeParameterStack[0] to {} for HTTP clients. This allows us to do the param() calls needed for both search and moodlogic/musicmagic full list plays. So in Slim::Player::HTTP:init() add this line before the $client->startup(): push @{$client->modeParameterStack}, {};
committed to r2827, let me know if we need it in 6.0.1 as well.
If the fix is safe, can it be considered for inclusion in 6.0.1 please?
vidur committed to 6.0.x branch in r2836
This bug was marked resolved in Slimserver 6.1, which is several versions ago. If you're still seeing this bug, please re-open it. Thanks!