Bug 12424 - Line-in support
: Line-in support
Status: CLOSED FIXED
Product: SB Radio
Classification: Unclassified
Component: Audio
: Include FW version in comment
: PC Windows XP
: P1 normal (vote)
: 7.4.0
Assigned To: Richard Titmuss
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-17 12:16 UTC by Richard Titmuss
Modified: 2009-10-05 14:31 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Titmuss 2009-06-17 12:16:23 UTC

    
Comment 1 Richard Titmuss 2009-07-27 01:09:40 UTC
Reset priority before triage.
Comment 2 Richard Titmuss 2009-08-07 09:03:00 UTC
 == Automatic comment from SVN commit #6955 to Repository: jive ==
https://svn.slimdevices.com/jive?view=revision&revision=6955

Bug: 12424
Description:
Support line-in with a loopback mode. This changes the audio alsa sample format to 
24LE, which will work better on the imx processors.

This does not work correctly yet, due to a kernel error on the capture port.




 == Modified 5 files total ==
7.4/private-branches/fab4/squeezeplay/src/squeezeplay/src/audio/decode/audio_helper.c
7.4/private-branches/fab4/squeezeplay/src/squeezeplay/src/audio/decode/decode.c
7.4/private-branches/fab4/squeezeplay/src/squeezeplay/src/audio/decode/decode.h
7.4/private-branches/fab4/squeezeplay/src/squeezeplay/src/audio/decode/decode_alsa.c
7.4/private-branches/fab4/squeezeplay/src/squeezeplay/src/audio/decode/decode_alsa_backend.c
Comment 3 Richard Titmuss 2009-08-07 09:04:52 UTC
 == Automatic comment from SVN commit #6956 to Repository: jive ==
https://svn.slimdevices.com/jive?view=revision&revision=6956

Bug #12424
Added capture device configuration.




 == Modified 1 files total ==
7.4/private-branches/fab4/squeezeplay/src/squeezeplay_baby/share/applets/SqueezeboxBaby/SqueezeboxBabyMeta.lua
Comment 4 Richard Titmuss 2009-08-07 09:07:13 UTC
 == Automatic comment from SVN commit #6316 to Repository: player ==
https://svn.slimdevices.com/player?view=revision&revision=6316

Bug #12424
Modified the dsp to use S24_LE input.




 == Modified 1 files total ==
squeezeos/7.4/trunk/squeezeos_dsp/src/babydsp_pcm.c
Comment 5 Richard Titmuss 2009-08-07 09:28:53 UTC
 == Automatic comment from SVN commit #6957 to Repository: jive ==
https://svn.slimdevices.com/jive?view=revision&revision=6957

Bug #12424
Add temporary menu option for testing line in.




 == Modified 1 files total ==
7.4/private-branches/fab4/squeezeplay/src/squeezeplay_baby/share/applets/TestAudioRouting/TestAudioRoutingApplet.lua
Comment 6 Richard Titmuss 2009-08-11 06:14:31 UTC
Updating time estimate.
Comment 7 SVN Bot 2009-08-13 15:04:25 UTC
 == Auto-comment from SVN commit #7068 to the jive repo by ccrome ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7068 ==

Bug #12424.  Force 32-bit I2S for all formats.  But 24bit audio with aplay arecord doesn't work.  Jive application still works.
Comment 8 James Richardson 2009-08-18 20:35:41 UTC
These are marked as CAT, yet that milestone is over now.  Please re-target accordingly.
Comment 9 SVN Bot 2009-08-20 04:43:34 UTC
 == Auto-comment from SVN commit #7166 to the jive repo by richard ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7166 ==

Bug #12424
Use S16_LE for line in, using 24 bits does not appear to work.
Comment 10 SVN Bot 2009-08-20 08:49:04 UTC
 == Auto-comment from SVN commit #7176 to the jive repo by richard ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7176 ==

Bug #12424
Fix line-in, we need to use the same sample format for capture and playback. This means we need to support 16-bit sample size for effects playback. Alsa gets confused if you store the capture directly in the playback buffer, so we need to use an temporary buffer to store the captured content.
Comment 11 SVN Bot 2009-08-21 03:26:16 UTC
 == Auto-comment from SVN commit #6349 to the player repo by richard ==
 == https://svn.slimdevices.com/player?view=revision&revision=6349 ==

Bug #12424
Change DSP to use S16_LE format.

The ALSA plugin api does not seem to allow this filter to (easily) work with S16_LE or S24_LE. As lin-in only works at the moment with S16_LE format, this means the crossover will have to use this format always.
Comment 12 SVN Bot 2009-08-21 05:01:32 UTC
 == Auto-comment from SVN commit #7190 to the jive repo by richard ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7190 ==

Bug #12424
Modify audio playback to support S24_LE or S16_LE formats.
Comment 13 SVN Bot 2009-08-21 05:04:04 UTC
 == Auto-comment from SVN commit #7191 to the jive repo by richard ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7191 ==

Bug #12424
Set sample size for all platforms.
Comment 14 SVN Bot 2009-08-21 06:34:18 UTC
 == Auto-comment from SVN commit #7192 to the jive repo by richard ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7192 ==

Bug #12424
Temporary UI for testing line-in.
Comment 15 Richard Titmuss 2009-08-21 06:35:02 UTC
Finally, working line-in support, but with a temporary UI for testing.
Comment 16 sbjaerum 2009-09-09 01:27:35 UTC
Is there a spec on how the line in is supposed to work?
More specifically, I am thinking about if there will be a Line In always on option.
Comment 17 James Richardson 2009-10-05 14:31:15 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.