Bug 12421 - ALAC native codec
: ALAC native codec
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Audio
: unspecified
: PC Windows XP
: P2 normal with 4 votes (vote)
: 7.5.0
Assigned To: Alan Young
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-17 12:12 UTC by Richard Titmuss
Modified: 2010-04-08 17:24 UTC (History)
4 users (show)

See Also:
Category: Feature


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Titmuss 2009-06-17 12:12:36 UTC

    
Comment 1 Richard Titmuss 2009-07-31 06:42:28 UTC
ALAC implementation added in r6860, but currently disabled. This works, but needs some debugging, especially on track changes. It may crash or make a horrid noise.

Dan, you expressed an interest in this codec. Would you be willing to fix the remaining bugs and test it? If not push the bug back my way, but it'll be unlikely to make the next release. Cheers, Richard.
Comment 2 Blackketter Dean 2009-08-03 08:29:31 UTC
Ping, Dan?
Comment 3 Dan Sully 2009-08-03 08:55:30 UTC
I started to take a look at this, but SqueezePlay, specifically SDL 1.2.3 doesn't compile on 10.6 ....
Comment 4 Pat Ransil 2009-08-22 10:22:37 UTC
from emails:
Dan,
 I double checked with Tom and Ben, and upgrading SDL right now is simply not possible. Updating SDL impacts all of our products that use SqueezePlay and its simply too risky (not to mention we don't have the cycles) to do at this point in our schedule. It was suggested that you open an enhancement request through Bugzilla and we can look at it as soon as we have time. Since Desktop SqueezePlay is not a supported product yet, there is no major urgency to make sure it works with Snow Leopard currently.

 (8.0 was suggested as a better time for us to get that upgrade put in...)

--Matt

On Aug 19, 2009, at 8:46 AM, Dan Sully wrote:

* Matt Wise shaped the electrons to say...

Do you think we just need to build ALAC on a Snow Leopard system with the
latest XCode?
The bug is on SDL side:
http://bugzilla.libsdl.org/show_bug.cgi?id=581

There is a patch available, but it needs an update to SDL:
http://permalink.gmane.org/gmane.comp.lib.sdl/36747

SDL v1.3 is needed, but it's still the dev version.
This is to build all of SqueezePlay, not ALAC specifically.

-D
Comment 5 Pat Ransil 2009-08-22 10:23:39 UTC
I am going to push this back to 8.0. If someone feels strongly that it needs to happen now, change it back.
thx
Pat
Comment 6 Jim McAtee 2009-10-14 20:39:31 UTC
Any chance this can be implemented for current ip3k players?  If not, what are the implications for syncing SP based players with ip3k players when playing ALAC?
Comment 7 SVN Bot 2010-01-21 03:48:07 UTC
 == Auto-comment from SVN commit #8386 to the jive repo by ayoung ==
 == https://svn.slimdevices.com/jive?view=revision&revision=8386 ==

bug 12421: ALAC native codec 
Re-enable to get more testing coverage.
Comment 8 SVN Bot 2010-02-24 09:09:02 UTC
 == Auto-comment from SVN commit #8567 to the  repo by ayoung ==
 == https://svn.slimdevices.com/?view=revision&revision=8567 ==

bug 12421: ALAC native codec 
Fix off-by-one error in MP4 sample handling.
Make ALAC init flag more robust.
Comment 9 Alan Young 2010-02-25 01:31:45 UTC
Still a problem with stream initialization sometimes.
Comment 10 Alan Young 2010-02-26 04:49:11 UTC
The plan is to make native the ALAC codec capability only visible for TinySC and ReadyNAS. All others will use server-side transcoding via the recently-upgraded  faad2 program.
Comment 11 SVN Bot 2010-02-26 05:31:29 UTC
 == Auto-comment from SVN commit #30261 to the slim repo by ayoung ==
 == https://svn.slimdevices.com/slim?view=revision&revision=30261 ==

bug 12421: ALAC native codec 
Only use native codec from SqueezeOS (TinySC) and ReadyNAS(sparc).
For all other platforms, which can support transcoding, the enhanced
capabilities of the faad2 transcoder with ALAC support provides a better solution.
Comment 12 SVN Bot 2010-02-26 05:31:35 UTC
 == Auto-comment from SVN commit #8586 to the jive repo by ayoung ==
 == https://svn.slimdevices.com/jive?view=revision&revision=8586 ==

bug 12421: ALAC native codec 
Only use native codec from SqueezeOS (TinySC) and ReadyNAS(sparc).
For all other platforms, which can support transcoding, the enhanced
capabilities of the faad2 transcoder with ALAC support provides a better solution.
Comment 13 Alan Young 2010-02-26 06:18:16 UTC
With the change to decode_alac.c:decode_alac_callback() to set the init flag only after successful initialization I am no longer able to reproduce the crash that I was seeing before.
Comment 14 Chris Owens 2010-04-08 17:24:42 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!