Bug 1238 - removing songs from playlist with add button can be annoying
: removing songs from playlist with add button can be annoying
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 6.0.0
: All All
: P3 normal (vote)
: ---
Assigned To: KDF
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-29 15:42 UTC by Kevin Pearsall
Modified: 2008-08-18 10:54 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
refreash playlist with better intelligence on going to now playing (3.97 KB, patch)
2005-05-11 01:18 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Pearsall 2005-03-29 15:42:04 UTC
when you press + to remove the song from the playlist, it bumps you back up to
the currently playing song in Now Playing...

it's annoying because if you want to do remove 2 songs in a row, you have to
press + on the remote, then scroll all the way back down to where you were and
press it again.

would be much nicer to just go to the next song once you've removed the song
you're on.
Comment 1 KDF 2005-05-10 15:14:01 UTC
I know what the problem is there Command::execute calls refreshPlaylist at the
end if the playlist is modified.  This sets the display to the current song,
after the removeTrack as properly positioned the display at the next song. 
working on a fix.
Comment 2 KDF 2005-05-11 01:18:05 UTC
Created attachment 513 [details]
refreash playlist with better intelligence on going to now playing

there is a lot here for what seemed a simple problem.  the refresh playlist
function would tend to jump to the now playing song, so a bit more brain were
needed in order to determine if playlist was showing now playing or browsing. 
showingnowplaying now stores the former value, and compares with current state.
 This way, watching now playing will update because the former state was
showing now playing.  Browsing up or down clears the former state, so a song
change, add, or delete wont force a jump to the current song.
Comment 3 KDF 2005-05-12 22:19:57 UTC
committed to 6.1 at change 3169
please test out and re-open if there is an issue.
Comment 4 Kevin Pearsall 2005-06-14 13:13:17 UTC
this is way better now.
Comment 5 Chris Owens 2008-03-11 11:28:03 UTC
This bug was marked resolved in Slimserver 6.1, which is several versions ago.  If you're still seeing this bug, please re-open it.  Thanks!