Bug 12122 - noweb-sqlite branch scanner fails to scan some mp3 files
: noweb-sqlite branch scanner fails to scan some mp3 files
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Scanner
: 7.4.0
: PC Ubuntu Linux
: -- normal (vote)
: 7.4.0
Assigned To: Andy Grundman
: Audio::Scan, SQLite, TestCase
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-20 21:51 UTC by Erland Isaksson
Modified: 2009-10-05 14:26 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
scanner.log (301.15 KB, text/plain)
2009-05-20 21:51 UTC, Erland Isaksson
Details
mp3 file that isn't scanned correctly (2.25 MB, application/octet-stream)
2009-05-20 21:55 UTC, Erland Isaksson
Details
Another mp3 that isn't scanned correctly (2.33 MB, application/zip)
2009-06-09 17:05 UTC, Erland Isaksson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Erland Isaksson 2009-05-20 21:51:47 UTC
Created attachment 5248 [details]
scanner.log

The noweb-sqlite branch scanner fails to scan some of my mp3 files.

In the scanner.log file I just get a message "Unable to read tags from file". The old MySQL scanner works perfectly on the same file.
Comment 1 Erland Isaksson 2009-05-20 21:55:30 UTC
Created attachment 5249 [details]
mp3 file that isn't scanned correctly
Comment 2 Erland Isaksson 2009-05-20 21:57:35 UTC
I should probably have mentioned that the log files is
from svn version 26700
Comment 3 Andy Grundman 2009-05-21 10:32:05 UTC
Hmm the file itself scans OK, I wonder if this could be a filename encoding issue.  Does it scan if you rename it to only contain ASCII chars?
Comment 4 Erland Isaksson 2009-05-21 14:35:02 UTC
(In reply to comment #3)
> Hmm the file itself scans OK, I wonder if this could be a filename encoding
> issue.  Does it scan if you rename it to only contain ASCII chars?

The file name doesn't matter, I tried to rename both the filename and directory so they only contains US ascii character but it didn't help. I also tried to put the file in a separate directory and pointed the music folder setting to this directory so it only scanned this single file, the problem still remains.

The SqueezeCenter information in SqueezeCenter Settings looks like this:
=========================
Version: 7.4 - TRUNK @ UNKNOWN
Hostname: squeezedev
Server IP Address: 172.16.0.211
Server HTTP Port Number: 9000
Operating system: Debian - EN - utf8
Platform Architecture: i686-linux
Perl Version: 5.8.8 - i486-linux-gnu-thread-multi
Total Players Recognized: 3
=========================

The operating system is Ubuntu 8.04.1 JeOS running in a virtualbox virtual machine. 

The file is scanned perfectly with the old MySQL based scanner in exactly the same setup.

I've other files with non ascii characters both in filename and tags that seems to scan perfectly.
Comment 5 Andy Grundman 2009-06-09 16:45:30 UTC
Is this still an issue with the latest 7.4?  I've changed a lot of stuff related to filename encoding.
Comment 6 Erland Isaksson 2009-06-09 17:00:07 UTC
(In reply to comment #5)
> Is this still an issue with the latest 7.4?  I've changed a lot of stuff
> related to filename encoding.

I just tried it with svn 26980 and have the same problem.
Comment 7 Erland Isaksson 2009-06-09 17:05:33 UTC
Created attachment 5320 [details]
Another mp3 that isn't scanned correctly

Here is another mp3 file that isn't scanned correctly, doesn't contain any non ascii characters as far as I can see. It does contain an apostrophe character, I'm not sure if that could cause any problems.
Comment 8 Andy Grundman 2009-06-09 17:15:10 UTC
OK, thanks, this one is actually not scanned properly.  It looks like the ID3 tag has a broken size value.
Comment 9 Erland Isaksson 2009-06-09 17:50:42 UTC
I tried it against my full production library. The FLAC version of the production library works perfectly, scans everything correctly. The MP3 version doesn't, it fails on a lot of files. If I remember correctly, the MP3 version of my production library has been created with the flac2mp3.pl script available through the forums.
The AAC version of my production library which I think is created with foobar2000 and the AAC iTunesEncoder seems to work pretty good. I get problem with one file but it seems to be caused by some other problem, I'll write a separate bug report for this.

The development library which the attached files are from has been created with various tools, some tagging with foobar2000 and Windows mp3tag and Linux id3v2.

I'm not sure if it's related, but the scanner process seems to die in the middle when scanning the MP3 production library. Is there some limitation so it aborts after it has failed to scan a specific number of files or is this something I should report in a separate bug report ?
Comment 10 Andy Grundman 2009-06-17 12:23:13 UTC
The problem here is similar to your other bug.. 5K of null bytes between the ID3 tag and the first MP3 frame.  The scanner only looks at 4K of data before giving up.  Why are your files so messed up? :)
Comment 11 Erland Isaksson 2009-06-17 13:51:21 UTC
(In reply to comment #10)
> The problem here is similar to your other bug.. 5K of null bytes between the
> ID3 tag and the first MP3 frame.  The scanner only looks at 4K of data before
> giving up.  Why are your files so messed up? :)

No idea. 

I think they were initially created from FLAC version with flac2mp3.pl (by Robin Bowes). Unfortunately I don't think I currently have the installation left to re-create them but I could try to experiment a bit with some of the FLAC to MP3 conversion tagging tools to see if I can recreate the problem.

All my MP3 files works perfectly with all other tagging tools I've used and also with the old SqueezeCenter 7.4 trunk scanner.
Comment 12 Andy Grundman 2009-06-17 14:23:31 UTC
Fixed in Audio::Scan 0.21.
Comment 13 James Richardson 2009-10-05 14:26:06 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.