Bug 12119 - "Install Update" button in PrefPane fails to update server
: "Install Update" button in PrefPane fails to update server
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Mac Installer
: 7.4.0
: Macintosh MacOS X 10.5
: P5 normal (vote)
: 7.4.0
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-20 17:42 UTC by Dan Evans
Modified: 2009-10-05 14:33 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
3 screenshots illustrating the error (67.99 KB, image/jpeg)
2009-06-02 09:59 UTC, Dan Evans
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Evans 2009-05-20 17:42:41 UTC
(using build 7.4 - 26555)

Our installer, in order to update, requires the System Prefs is closed.  But the only way to click on "Update Now" is from within the PrefPane.

If you click on "Install Update" our installer runs, pops up a window with an "Update" button, but... clicking on that button gets an error stating, "Please quit System Preferences before running the installer.

Even shutting down System Prefs prior to press the "Update" button from our installer still fails with that error.

I will try with today's build and see if behavior is changed.

...

It may be that updating is broken in general.  Downloading latest build (26688) and running as update fails in the same way.
Comment 1 Michael Herger 2009-05-20 23:21:05 UTC
Dan - wouldn't the PrefPane eventually close? That part of the installer has not been changed in months - I would be surprised if this was a real issue.

FWIW: I've added a delay of a few seconds during which the installer will wait for the PrefPane to be closed. Please see whether you can still reliably reproduce this. Thanks!

> Even shutting down System Prefs prior to press the "Update" button from our
> installer still fails with that error.

This sounds like some preference pane is blocking your system. Looking at the activities monitor do you still see it running?
Comment 2 Dan Evans 2009-05-21 09:26:32 UTC
Michael-- I think you're right.  

I reboot my Mac rather infrequently.  I think there was a rogue process that was not allowing SysPrefs from fully shutting down.  What led me to this was I updated to yesterday's nightly and I had exactly the same problem from a clean install of SC.

I rebooted my Mac and it installed fine.  

I will monitor this but I'm going to close this bug.
Comment 3 Dan Evans 2009-06-02 09:59:41 UTC
Created attachment 5300 [details]
3 screenshots illustrating the error

I am reopening this bug.  I saw this again this morning trying to update build 26738.  This was after a fresh boot.

Screenshot attached showing the sequence that appears: 1) I've clicked Update, 2) Prefs has closed and I enter password, 3) Update fails.

Let me know what server log options you'd like on to get details on this?
Comment 4 Michael Herger 2009-06-02 11:11:19 UTC
do you have any other funky 3rd party pref panes installed? Do you see this on various machines? Which OSX version?
Comment 5 Dan Evans 2009-06-02 16:25:12 UTC
System Version: Mac OS X 10.5.7 (9J61) 

I do have a couple 3rd party Panes, but I don't know if they're "funky". ;)  My "Other" list in System Prefs is: Logitech Control Center, DivX, SqueezeCenter, SynergyKM.

I only see this on my machine, sadly.  Tried it on 2 other systems in Support and it works fine.  Looking at the Activity Monitor it appears that System Prefs does not completely shut down sometimes.  There's a lingering process.  I kill that process and it works fine.
Comment 6 Michael Herger 2009-06-02 22:28:33 UTC
> I only see this on my machine, sadly.  Tried it on 2 other systems in  
> Support and it works fine.  Looking at the Activity Monitor it appears  
> that System Prefs does not completely shut down sometimes.


I'm really not sure there's a lot we can do. We tell the PrefPane to exit,  
which it usually does. If it decides not to do so, then this is out of our  
control. I don't want to kill tasks systematically the hard way.
Comment 7 Dan Evans 2009-06-03 10:50:53 UTC
Closing again.  If it appears on systems beyond just my own, we'll reopen.
Comment 8 Michael Herger 2009-06-03 22:09:45 UTC
Maybe we'll just need to wait a bit longer. Or better listen to the closing call to quicker shut down our own prefpane or something.
Comment 9 Michael Herger 2009-06-29 06:29:11 UTC
closing again
Comment 10 James Richardson 2009-10-05 14:33:00 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.