Bug 12057 - Artist & album lines don't scroll
: Artist & album lines don't scroll
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Now Playing
: unspecified
: PC Windows XP
: P1 normal (vote)
: 7.4.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-14 15:28 UTC by radish
Modified: 2009-10-07 07:45 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description radish 2009-05-14 15:28:44 UTC
Only the Title line in Now Playing scrolls, the Artist and Album lines crop the end text when it's too long.

This is with:

r5737
SC 7.4 - 26558 @ Thu May 14 01:25:07 PDT 2009
Comment 1 Ben Klaas 2009-05-28 14:29:14 UTC
FYI, from Fab4 Campfire chat on May 27th. A detailed description of why this bug is present.

Triode
are the three lines independant - so they scroll independantly if allowed?

Ben K.	
they are now 3 separate label widgets, which was done for other (good) reasons, but produced this bug as a side effect

Triode	
only one widget can scroll on the screen at once? (rather than all scroll independantly?)

Ben K.	
only the focused widget will scroll. as it stands right now, the track label widget is the one with focus.
it previously worked because it was one label with three lines of text.

Triode	
one thing I've seen work well is scrolling each extra long line in turn. can we move the focus when the scrolling is stationary
does the focus also define the bolder text?

Ben K.	
yes, that's a possibility. don't know if there's an easy way in Lua right now to say widget:isScrolling()
Comment 2 James Richardson 2009-06-08 13:19:44 UTC
The widget with 'focus' is able to scroll, the other 2 are not.  There needs to be a way to switch focus
Comment 3 Ben Klaas 2009-08-03 07:52:40 UTC
issue is a bit changed with NP redesign, but there's still an issue with scrolling the unfocused widget(s)
Comment 4 Seth Schulte 2009-08-06 12:09:30 UTC
Copying Matt. Does the NP design specify the desired scrolling behavior?
Comment 5 Weldon Matt 2009-08-06 13:36:55 UTC
Is this a fab4 bug or a Squeezeplay bug?  Not all Squeezeplay devices have 3 lines of text on the Now playing screen...

Of course we need truncated items here to scroll. Noah did the most recent work on this, but I believe the plan was for the UI to "cycle" through truncated items.  So the top truncated line would scroll through, then stop at the beginning, then the second truncated item would scroll, then stop, and so on, with the process repeating as needed.

I believe this is the functionality that existed before?

(Added required access to baby bugs since I think the issue is different right now on baby vs fab4, i.e. 2 lines vs. 3)
Comment 6 Ben Klaas 2009-08-06 14:26:12 UTC
This is a squeezeplay bug

The ONLY thing that will scroll currently is the focused widget. We've gotten around that in the past by doing multi-line items as a single widget, which I really think is a mistake (and may not even be feasible in the skin redesign).

There's some needed discussion on both how we want this to work (should all things that truncate on all windows eventually scroll? Even for e.g. non-selected albums in album lists?), and how we want to implement it (e.g., cycle scrolling by cycling which widget is focused?)

I'm adding 4 hours to the time estimate on this one...methinks it will be tricky to do right.
Comment 7 Richard Titmuss 2009-08-06 14:35:35 UTC
Ben it's probably not too tricky. Discuss it with me before you start on this one.
Comment 8 SVN Bot 2009-08-13 08:53:12 UTC
 == Auto-comment from SVN commit #7059 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7059 ==

Fixed Bug: 12057
Animate trackTitle, XofY, and artistalbum lines in Now Playing screen
Separate bug will be opened against Fab4 NP, which is now not-to-spec
Comment 9 James Richardson 2009-10-05 14:33:52 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 10 radish 2009-10-07 07:45:41 UTC
I originally reported this on Touch before it was made a SP bug. It's marked closed but the latest 7.5.0 fw for Touch still has the problem. Comment #8 indicates that a new bug has/will be opened for Touch specifically but I can't find it. Any pointers?