Bugzilla – Bug 12013
touch-hold on title in title bar should bring up context menu for the container
Last modified: 2010-04-08 17:25:59 UTC
should be the same as going left, then touch-holding on the item in question.
*** Bug 12251 has been marked as a duplicate of this bug. ***
moving current p2 bugs to p3 to make room for moving p1.5 bugs to p2
Administrative move of 7.5 bugs. All P2, P3, P4 being downgraded one level. Will then split P1s.
Created attachment 6574 [details] incomplete patch for bug 12013 The patch is functionally working, but there is more UI/skin work and testing to be done. 1. try to find a way for XMLBrowse items that have no context menus (e.g., Napster Artists) to not render a button in the title bar 2. s.text_list.text changes in skin have screwed up some other UI items (see pressed menu item behavior) 3. pressed style of title bar button is all wrong.
== Auto-comment from SVN commit #8596 to the jive repo by bklaas == == https://svn.slimdevices.com/jive?view=revision&revision=8596 == Fixed Bug: 12013 Description: Title bar for local music browse windows will be deliver a context menu when touched if the menu item from the previous window had a context menu intentionally disabled for XMLBrowse items (internet radio, online services) because there is currently no way to decide whether a title's text should be "buttonized" along the XML browse tree skin support in WQVGAsmall (touch skin) to render it as a button skin support in QVGAbase and WQVGAlarge for textButton to render it the same as text
== Auto-comment from SVN commit #8597 to the jive repo by bklaas == == https://svn.slimdevices.com/jive?view=revision&revision=8597 == Bug: 12013 Description: turn animation of label widget off when button treatment is given in title bar
Ben the cause of your problem is the fetching of the title text in Window.lua. You have a highly nested widget here with groups inside buttons inside groups. This causes Window:getTitle to fail and this causes the bounds of the widget to get set wrongly for some reason. The following seems to make it work: --- squeezeplay/share/jive/ui/Window.lua 2010-01-15 21:52:38.000000000 +0000 +++ ../build/linux/share/jive/jive/ui/Window.lua 2010-02-28 23:10:39.000000000 +0000 @@ -769,8 +769,10 @@ --]] function getTitle(self) if self.title then - if self.title:getWidget('text') then + if self.title:getWidget('text').getValue then return self.title:getWidget('text'):getValue() + else + return self.title:getWidget('text').widgets[1]:getValue() end end However - this is tuned to your specific and very strange widget hiearchy and I don't think is a strategic solution... If you want a work arounds like this then we should make the seconds part more defensive
== Auto-comment from SVN commit #8609 to the jive repo by bklaas == == https://svn.slimdevices.com/jive?view=revision&revision=8609 == Bug: 12013 Description: skip menu lock treatment when it is not applicable, e.g., when touching on a callback that isn't in a menu like the title bar
Ben, the Now Playing screen works with a Label as the Button contents - can you use this widget hierachy for Slim Browser as it would avoid needing special case changes to Window.lua for this problem..
No, it doesn't work at all in terms of skinning. Have you set it as a Label and successfully had the button graphic treatment work? I didn't encase the label in a group by choice-- it was the only way I could get any success with the bgImg style.
I should note, it also renders the button callback unusable if I use Label('textButton') instead of Group('textButton', { Label()} )
Created attachment 6584 [details] screenshot when Group widget is used. Skin style and button callback work
Created attachment 6585 [details] screenshot when Label widget is used. Skin style and button callback fail
== Auto-comment from SVN commit #8627 to the jive repo by bklaas == == https://svn.slimdevices.com/jive?view=revision&revision=8627 == Bug: 12013 Description: clean up title widget button so it uses a label instead of a nested label in a group tidy up skins to support that change add back animation to text label now that it is no longer broken after this change
== Auto-comment from SVN commit #30326 to the slim repo by bklaas == == https://svn.slimdevices.com/slim?view=revision&revision=30326 == Bug: 12013 Description: remove titleStyle param from window definitions in menus to SP. These have been deprecated for more than a year.
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release. If you are still seeing this issue, please let us know!