Bugzilla – Bug 11954
divider lines aren't needed between volume icons and slider
Last modified: 2009-09-08 09:28:29 UTC
they break up the volume control into three different controls. The divider lines should be removed and the bar grown to fill in some of the extra space.
Created attachment 5181 [details] screenshot without divider between icons and slider my two cents is that this doesn't look right. the volume up/down buttons are functional buttons. without the dividers they look like they are just indicators for the slider and aren't functional themselves.
assign back to Dean for comment. This is trivially easy whatever is decided, but I think what we currently have is correct.
I agree. The buttons need a break/divider line to read as buttons. Without them they are inconsistent with the other elements on the toolbar and do not indicate that they can be pressed. We would need to remove all divider lines for this to work...
I spoke to Noah in person and he's going to take a look at finding a look for this that makes the volume control feel like a single widget but not compromise the notion that you can touch the icons. It might be as little as tweaking the amount of negative space to be more balanced, or a lighter divider.
As a start we should correct the spacing of the volume +/- buttons to spec. The correct width is 36px. Please see attached guideline from svn.
Created attachment 5535 [details] Guideline - NP correct toolbar button spacing
Dean - I have taken a look at this and we cannot change the volume button treatment without changing ALL the toolbar indicators. There was a strong directive to have separators between each button. The press states, dividers, and spacing were developed based on this decision. Options: 1. Remove the divider lines from ALL buttons and develop new visual indicator for press state (not desirable based on spillout to other assets and treatments). 2. Adjust the spacing (width of button) and keep the visual treatment as is. Correcting the spacing will give more length for the slider which is the 2nd part of your original filing.
Created attachment 5539 [details] Ref artwork - volume press
Reassigning to Weldon for comment.
Noah and I have discussed this extensively and it just isn't workable. The aesthetic argument on both sides is a subjective one anyway - this doesn't hurt functionality.