Bug 11930 - Volume slider assets are broken
: Volume slider assets are broken
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: UI Skin
: unspecified
: PC Other
: P1 major (vote)
: 7.5.0
Assigned To: Wadzinski Tom
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-29 20:35 UTC by Ben Klaas
Modified: 2010-04-08 17:25 UTC (History)
7 users (show)

See Also:
Category: ---


Attachments
screenshot of broken volume slider (81.87 KB, image/png)
2009-04-29 20:35 UTC, Ben Klaas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2009-04-29 20:35:44 UTC
Created attachment 5171 [details]
screenshot of broken volume slider

there are four assets for the volume slider and we currently have no means of layering those items for the widget. If this is going to work as specified it will require some lower level code to support it

for now, assigning to Richard
Comment 1 Ben Klaas 2009-06-04 11:02:06 UTC
*** Bug 12259 has been marked as a duplicate of this bug. ***
Comment 2 James Richardson 2009-06-05 11:08:30 UTC
Also: pressing and holding on the Vol UP/DOWN buttons do not work
Comment 3 Blackketter Dean 2009-07-22 09:02:24 UTC
Moving to the product SqueezePlay because this bug appears to apply to any player based on that application code.  Feel free to move it back if it's specific to the original product.
Comment 4 Richard Titmuss 2009-07-30 03:51:33 UTC
Need to discuss with Tom about new slider implementation.
Comment 5 Seth Schulte 2009-08-05 10:34:29 UTC
Moving this out since I believe it only applies to Fab4, right?

Please correct me if I'm wrong and I'll move it back in.
Comment 6 Matthew J. Martin 2009-08-05 10:39:59 UTC
Correct. As of 7.4 r6887 still broken on Touch

On Wed, Aug 5, 2009 at 10:34 AM, <bugs@bugs.slimdevices.com> wrote:
> https://bugs-archive.lyrion.org/show_bug.cgi?id=11930
>
>
> Seth Schulte <seth_schulte@logitech.com> changed:
>
> � � � � � What � �|Removed � � � � � � � � � � |Added
> ----------------------------------------------------------------------------
> � � � � � � � � CC| � � � � � � � � � � � � � �|seth_schulte@logitech.com
> � Target Milestone|7.4 � � � � � � � � � � � � |8.0
>
>
> --- Comment #5 from Seth Schulte <seth_schulte@logitech.com> 2009-08-05 10:34:29 PDT ---
> Moving this out since I believe it only applies to Fab4, right?
>
> Please correct me if I'm wrong and I'll move it back in.
>
> --
> Configure bugmail: https://bugs-archive.lyrion.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.
>
Comment 7 Richard Titmuss 2009-09-29 04:17:05 UTC
Tom, lets discuss with Ben a new slider implementation for 7.5 at the on-site.
Comment 8 SVN Bot 2009-10-27 08:03:56 UTC
 == Auto-comment from SVN commit #7937 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7937 ==

Bug: 13000
Bug: 11930
Description: remove white "fill" on left of volume slider to workaround UI problem of not being able to deliver 4 slider assets. This is not a fix for bug 11930, but may push it from P1 to P2.
Make volume popup render correctly in both small and large text screens
Comment 9 SVN Bot 2009-10-28 09:42:57 UTC
 == Auto-comment from SVN commit #7961 to the jive repo by tom ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7961 ==

Bug: 11930 +4
Description:
- C work done, passing to Ben for ui work
Comment 10 Wadzinski Tom 2009-10-28 09:43:56 UTC
C work done, passing to Ben
Comment 11 SVN Bot 2009-10-28 10:14:49 UTC
 == Auto-comment from SVN commit #7963 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7963 ==

Bug: 11930
Description: work in progress checking in so Tom can give it a spin
using test assets right now while this is not complete
Comment 12 SVN Bot 2009-10-28 10:18:57 UTC
 == Auto-comment from SVN commit #7964 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7964 ==

Bug: 11930
Description: test asset update
Comment 13 SVN Bot 2009-10-28 10:28:55 UTC
 == Auto-comment from SVN commit #7965 to the jive repo by tom ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7965 ==

Bug: 11930
Description:
- temporary y offset for testing...
Comment 14 SVN Bot 2009-10-28 12:28:03 UTC
 == Auto-comment from SVN commit #7967 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7967 ==

Bug: 11930
Description: asset work in progress. these are about to move to a different location...
Comment 15 SVN Bot 2009-10-28 12:30:19 UTC
 == Auto-comment from SVN commit #7968 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7968 ==

Bug: 11930
Description: volume asset work in progress
Comment 16 Ben Klaas 2009-10-28 13:15:42 UTC
What I have checked in is as far as it's likely to get on the skin coding side.

When volume is at 0 there is ~1px of white showing to the left of the "pill"

When volume is at 100 it goes slightly beyond the "hug point" where the round edge of the pill meets the round edge of the empty progress bar.

neither of these issue are probably P1 at this point, but it's the Vol 0 side that I'd prefer fixed if I had to pick...
Comment 17 ndijulio 2009-10-28 13:19:47 UTC
What is the Volume position set to out-of-box? 50% would aid this ~1px problem.  Let me know if something can be corrected in the asset...
Comment 18 SVN Bot 2009-10-30 08:24:00 UTC
 == Auto-comment from SVN commit #7980 to the jive repo by tom ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7980 ==

Bug: 11930 +2
Bug: 11976 +6
Description:
- Volume slider finger now sticks to pill
- Scrollbar bottom compensation added for fab4.
Comment 19 Wadzinski Tom 2009-11-02 09:27:49 UTC
I think volume slider behavior/ui is now ready.
Comment 20 Chris Owens 2010-04-08 17:25:16 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!