Bug 1191 - firmware.html page for updating squeezebox1 is broken in 6.0 beta
: firmware.html page for updating squeezebox1 is broken in 6.0 beta
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 6.0.0
: All All
: P2 major (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-25 09:28 UTC by Kevin Pearsall
Modified: 2008-08-18 10:53 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Pearsall 2005-03-25 09:28:35 UTC
Can't call method "upgradeFirmware_SDK4" without a package or object reference
at /Users/kpearsall/6/server/Slim/Player/Squeezebox.pm line 428.
Comment 1 Kevin Pearsall 2005-03-25 09:31:13 UTC
reproduced in r2719.  customer reported bug.  he's trying to update a sub-rev-10
sb1.
Comment 2 Kevin Pearsall 2005-03-25 10:22:29 UTC
broken from 5.3.0 and on, actually.  to get sub-10 fw upgraded you have to:
- use 5.3.0-5.4.1 to get up to fw 10.
- drop back to 5.2.1 to get upgraded to fw 29.
- go to 5.4.0+ to get up to fw 40.
Comment 3 Blackketter Dean 2005-03-25 10:29:00 UTC
This should fix it: 

Index: Slim/Player/Squeezebox.pm
===============================================================
====
--- Slim/Player/Squeezebox.pm   (revision 2720)
+++ Slim/Player/Squeezebox.pm   (working copy)
@@ -430,7 +430,7 @@
 
        if ((!ref $client) || ($client->revision <= 10)) {
                $::d_firmware && msg("using old update mechanism\n");
-               $err = $client->upgradeFirmware_SDK4($filename);
+               $err = upgradeFirmware_SDK4($client, $filename);
        } else {
                $::d_firmware && msg("using new update mechanism\n");
                $err = $client->upgradeFirmware_SDK5($filename);
Comment 4 Blackketter Dean 2005-03-25 10:40:40 UTC
Fixed for next nightly.  Please test with a pre-10 firmware player.