Bugzilla – Bug 11866
Diagnostics HTTP port display
Last modified: 2010-09-13 12:01:49 UTC
I have SqueezeCenter running on HTTP port 80 by virtue of the --httpport command line option. Shouldn't the Diagnostics screen reflect this, instead of displaying 'TCCP port 9000: Can't connect'?
Good point - need to fix this in the control panel applets too.
Change 26170 - read httpport from SC's configuration in the control panel's diagnostics
I'm still seeing the same thing in the Diagnostics screen.
In which diagnostics screen? I only fixed it in the Windows control panel, but not on the device menu. That would rather be a Ben or Richard job.
Windows control panel? Sorry, I'm not familiar with that at all. I was talking about on the device.
Thanks Jim. Correct, the device menu hasn't been changed yet. That's why I left the bug open after I've fixed the control panel. It's started from the tray icon (if running the Windows binary) or "perl cleanup.pl". Ben/Richard - may I hand this over to you?
this is an administrative shuffle on priority fields to help make better judgment on the top end of the priority list. P4->P5, P3->P4, and P2->P3.
7.4.x milestone is in the past
A diagnose screen should return correct results or it's useless. Let's fix this.
Created attachment 6709 [details] change port 9000 to whatever actually is being used
Created attachment 6710 [details] change port 9000 to whatever actually is being used
Created attachment 6711 [details] UNTESTED patch to allow for multiple args to the self:string() in setValue() Michael, give this one a try. This uses the "..." magic to pass optional n values between a few methods, then in setValue() it brings ... into a table, tests for that table having size, and then pre-inserts the ... to self:string() method. Can you give this a shot and let me know how it goes?
Created attachment 6712 [details] UNTESTED patch (v2) to allow for multiple args to the self:string() in setValue() slight tweak to previous patch. add SC_WEB_PORT to tests table, make sure that we do something sane with that item when connected to mysb.com
Created attachment 6724 [details] working patch using Ben's approach Ben - using ... somehow didn't work. I decided to go with one additional, optional "arg" parameter, which now is working.
at some point we should figure out why the ... didn't work. There's no reason that it shouldn't have worked there, and by not using it you limit yourself from n optional args to 1 arg
The most important part might be that we're using a closure, which is a different context for ... Maybe with some proper placing of the ... you'll be able to make it work too.
Targeting for 7.5.1 at Ben's suggestion that all patch_waiting bugs be fixed
== Auto-comment from SVN commit #8680 to the jive repo by mherger == == http://svn.slimdevices.com/jive?view=revision&revision=8680 == Fixed Bug: 11866 Description: display/test actual SBS http port instead of hard-coded value 9000
Since these are fixed, they must not be patch_waiting after all