Bugzilla – Bug 11839
On wireless network failure, button text is "Re-enter your password" even for unprotected AP
Last modified: 2009-09-08 09:19:07 UTC
If there is a failure connecting to a wireless AP, a button appears saying "Re-enter password", but the AP is completely open, so there is no password to enter. Clicking re-enter password works (if the connection works), but the text is incorrect. This only came up when I tried to reconnect to an unplugged router than I had previously connected to. When I plugged it in then, I clicked Re-enter password and I got connected. That's a bit of an odd case, but I'm guessing there are other situations were the same error would occur for an open AP. Here's the relevant code: function _connectFailed(self, iface, ssid, reason) assert(iface and ssid, debug.traceback()) log:debug("connection failed") -- Stop trying to connect to the network, if this network is -- being added this will also remove the network configuration Task("networkFailed", self, _connectFailedTask):addTask(iface, ssid) -- Message based on failure type local password = "" if self.encryption then if string.match(self.encryption, "^wep.*") then password = self.key elseif string.match(self.encryption, "^wpa*") then password = self.psk end end local helpText = self:string("NETWORK_CONNECTION_PROBLEM_HELP", password) -- popup failure local window = Window("error", self:string('NETWORK_CANT_CONNECT'), 'setuptitle') window:setAllowScreensaver(false) local menu = SimpleMenu("menu", { { text = self:string("NETWORK_TRY_PASSWORD"), sound = "WINDOWHIDE", callback = function() _networkScanAgain(self, iface, true) _enterPassword(self, iface, ssid, "config") end },
It would be best to have this fixed for MP. Do we have a simple 'Try Again' string that we can use in the case of an unsecured router? CCing Matt Weldon for feedback if he wants to give it quickly.
Yes, "Try again" would be the correct string. We're using it in at least one place, screen "7M" (WPS Timeout) http://embargo.wiki.slimdevices.com/index.php/New_Setup_Wizard#SCREEN_7M_-_ERROR_-_WPS_Timeout
Fixed in r5418 Ben reviewed it and we tested out the various scenarios.