Created attachment 5127 [details]
patch

Assigning to Ben for patch review..

you need to rename settingsShow method to something that's more indicative of the applet. settingsShow is not a reasonable name of something that can be called from outside the applet. 

I'd suggest softwareUpdateMenu or some such thing.

Tweaking to correct target.

Committed with Ben's suggestion in r5310

This addition needs review.  Behavior as I see it now:

 1. If only 1 media source is available, with only 1 firmware, you get, "Install from removable media ... >Begin Update".  

 2. If multiple media sources and/or firmwares are available, you get a list of fw to choose from notated as <fw number> but no text about "install from removable media."

 3. If no sources are available, you get only, "Cancel"

We need consistency between #1 and #2, and #3 is confusing.

=====

Proposal:

 * Case 1 says, "Install from removable media ... >Update to <fw number>"
 * Case 2 says, "Install from removable media ... >Update to <fw number>" + lists as many items as it finds
 * Case 3 says, "No removable media detected ... >Cancel"

Please target milestone as appropriate.

=====

Additionally...

* On this Software Update screen, the screensaver will engage.

* Inserting an SD card here can reboot the device.  (it did on my first test, but did not on several subsequent tests.)

targeting based on Dan's and Dean's feedback

This firmware update screen needs some love.  

I propose text like this:

Begin Update      >

if there is only one update available and it's from the network. (Which is what we have now)  

If there are any on removable media, then change to this:

Update to version W.X.Y rZ from USB  >

or

Update to version W.X.Y rZ from SD card >

or 

Update to version W.X.Y rZ from network >

and omit the supporting text that happens with the Begin Update screen.

Moving Matt Weldon bugs

Unassigned bugs cannot have a priority.