Bug 11802 - track information is gathered in several places, not always returning the same results
: track information is gathered in several places, not always returning the sam...
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: CLI
: 7.4.0
: PC Other
: P2 normal (vote)
: 7.4.0
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-15 01:50 UTC by Michael Herger
Modified: 2009-10-05 14:36 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Herger 2009-04-15 01:50:00 UTC
Related to bug 11233 - we have several commands which return track information:

playlist artist|album|genre|etc.
artist|album|genre|etc.
songinfo
status

probably more. Most of them use their own way to collect data, instead of all using _songInfo(). This leads to different results depending on what query is used. Instead of fixing it in all places, we should make them all use the same common sub routine.

Ben - I'm adding you to this bug as some of the heavily Jive menu related code is involved too. In case I'm breaking something, at least you know why :-)
Comment 1 Adrian Smith 2009-04-15 03:02:48 UTC
Could I suggest linking this to whether remote tracks should go into the database at all.  

There's also the question of what the artist should be for a track - I am not sure all of the cases honor the (slow) contribtutors stuff vs just fetching the first artist.  I think this needs a policy decision to be made as the jive db calls were getting less than the web ones at one time.
Comment 2 Michael Herger 2009-04-15 03:19:05 UTC
Good comment. I think getting them all to use the same code will help us a  
lot fixing the bigger issues later.
Comment 3 Michael Herger 2009-04-15 03:39:57 UTC
One more thing we should get rid of: title vs. current_title vs.  
remote_title. I don't know myself what is supposed to do what. And there's  
special handling of current_ and remote_ in too many places.
Comment 4 Michael Herger 2009-04-15 03:53:01 UTC
change 25964 - change _addJiveSong to use common _songData() track data  
parser
Comment 5 Michael Herger 2009-06-30 06:01:10 UTC
Alan - is comment #3 of this covered by the metadata rework you're doing?
Comment 6 Alan Young 2009-06-30 09:00:16 UTC
yes
Comment 7 James Richardson 2009-10-05 14:36:51 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.