Bugzilla – Bug 1180
merge track list handling to common code
Last modified: 2008-08-18 10:54:16 UTC
Import mixes, search results, current playlist and browse lists are all examples of track listings. Currently, there are 5 different codesets to handle the 5 different cases. Pages.pm has a %fieldInfo hash that could perhaps be expanded to provide the complete set of objects for all cases. This way the HTML for the lists can be common, and the handlers can simply call to common code.
Created attachment 373 [details] quick test quick feasability test on this with musicmagic. it easily adds the mixerlinks with a lot less code. It still broken on albums and artist. I think even browsedb seems to have done things outside of the fieldInfo hash. clearly possible, and clearly lots to do. I'll take it on post 6.0 somewhere, but I will need this patch for reference later.
*** Bug 1284 has been marked as a duplicate of this bug. ***
*** Bug 1585 has been marked as a duplicate of this bug. ***
Created attachment 520 [details] udpated patch This one includes the recent musicmagic fixes as well. What I've done is to make use of the %fieldInfo in Pages.pm for as many cases of track listings as possible. LiveSearch is stuck for now, as it is hardcoded. This now allows moodlogic and musicmagic to use browsedb_list.html instead of custom html for lists. I'm planning to commit this to 6.1 tonight, unless there are some objections. I've fixed browsedb_list for Fishbone, EN, Default and Default2 since [%webroot%] must be used to make it compatible with the plugins. I'm not sure which other skins(if any) have support for the importers.
committed to 6.1 at change 3272 this includes mixerlinks for search, and mix results skins can now rely on browsedb_list.html for mixer lists. skins will have to update this file to use [% webroot %] if they support the importers. Fishbone, Default, Default2 and EN are already changed. re-open if any issues remain.
This bug was marked resolved in Slimserver 6.1, which is several versions ago. If you're still seeing this bug, please re-open it. Thanks!