Bug 11773 - Screensaver does not allow preview from SB Touch
: Screensaver does not allow preview from SB Touch
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Screensavers
: unspecified
: PC Other
: P1 normal (vote)
: 7.5.0
Assigned To: Ben Klaas
: SLT
Depends on: 12023
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-12 07:59 UTC by Blackketter Dean
Modified: 2010-04-08 17:24 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2009-04-12 07:59:51 UTC
The screensaver chooser menu has fixed explanatory text and an arbitrarily long list of screensavers.  

The text is fixed in place, and the list scrolls, but the bottom of the list isn't visible and can't be selected.

The text needs to be customized for Fab4 and have the whole body area (supporting text plus menu selections) scroll together.

Propose this text:

Touch to select a screensaver to be shown when this Squeezebox is not playing.  Touch and hold to preview a screensaver.
Comment 1 Ben Klaas 2009-04-13 08:57:43 UTC
*** Bug 11782 has been marked as a duplicate of this bug. ***
Comment 2 Ben Klaas 2009-04-13 12:12:49 UTC
*** Bug 11785 has been marked as a duplicate of this bug. ***
Comment 3 Ben Klaas 2009-04-21 15:32:06 UTC
r5424 has an interim workaround that suppresses the help text

I'm not sure what the end solution is for this-- we typically don't have platform-independent applets deliver platform-specific text

bug still open, but behavior on fab4 will be better in the interim
Comment 4 Ben Klaas 2009-07-16 09:09:15 UTC
changing several bugs at once-- target milestone on these do not apply to the CXR/CAT milestone
Comment 5 Blackketter Dean 2009-07-22 09:02:18 UTC
Moving to the product SqueezePlay because this bug appears to apply to any player based on that application code.  Feel free to move it back if it's specific to the original product.
Comment 6 Wadzinski Tom 2009-07-27 08:15:18 UTC
r6786 - added speculative strings based on Dean's original comment. Not yet used.

+SCREENSAVER_SELECT_PLAYING_HELP
+       EN      Press the center button to select a screensaver to be shown when this Squeezebox is playing.
+
+SCREENSAVER_SELECT_STOPPED_HELP
+       EN      Press the center button to select a screensaver to be shown when this Squeezebox is not playing.
+
+SCREENSAVER_SELECT_OFF_HELP
+       EN      Press the center button to select a screensaver to be shown when this Squeezebox is off.
+
+SCREENSAVER_SELECT_PLAYING_HELP_FAB4
+       EN      Touch to select a screensaver to be shown when this Squeezebox is playing.
+
+SCREENSAVER_SELECT_STOPPED_HELP_FAB4
+       EN      Touch to select a screensaver to be shown when this Squeezebox is not playing.
+
+SCREENSAVER_SELECT_OFF_HELP_FAB4
+       EN      Touch to select a screensaver to be shown when this Squeezebox is off.
+
+SCREENSAVER_PREVIEW_HELP
+       EN      Press play to preview a screensaver.
+
+SCREENSAVER_PREVIEW_HELP_FAB4
+       EN      Touch and hold to preview a screensaver.
+
Comment 7 SVN Bot 2009-08-30 06:55:38 UTC
 == Auto-comment from SVN commit #7333 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7333 ==

Bug: 11773
Description: add help to header widget for non-Fab4 platforms. This bug will still need addressing for Fab4, as header widgets are currently mostly broken in that skin.
Comment 8 SVN Bot 2009-08-30 06:57:13 UTC
 == Auto-comment from SVN commit #7334 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7334 ==

Bug: 11773
Description: also remove menu header widget from desktop squeezeplay to allow screensaver menu + fab4 skin on desktop
Comment 9 Ben Klaas 2009-08-30 06:58:13 UTC
this is fixed for 7.4/P1.

Still needs fixing for Fab4

   -- Bug: 1173, don't show this header widget yet on fab4
        if System:getMachine() ~= 'fab4' and System:getMachine() ~= 'squeezeplay' then
                menu:setHeaderWidget(Textarea("text", self:string("SCREENSAVER_SELECT_HELP")))
        end
Comment 10 SVN Bot 2009-10-19 20:22:46 UTC
 == Auto-comment from SVN commit #7904 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7904 ==

Bug: 11773 +1
Description: Fab4-specific strings show in menu header widget now
Comment 11 Ben Klaas 2009-10-19 20:30:29 UTC
changing the title of the bug to reflect its current state

also, the strings that Tom added on 7/27 will probably need some merging if all the text is to be delivered with one string.

currently the menu header widget for Fab4 only describes how to select one (which works for now since you can't successfully preview anyway. woot!)
Comment 12 SVN Bot 2009-10-20 09:51:57 UTC
 == Auto-comment from SVN commit #7908 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7908 ==

Fixed Bug: 11773 +2
Description: allow 'add' action to preview a screensaver, which on SB Touch is a touch-hold. 
This also enables the + key elsewhere for screensaver preview (in addition to the play key), but Tom and I both agreed this was not a bug.

Concatenated select and preview strings as they are delivered in one help message
Comment 13 Chris Owens 2010-04-08 17:24:40 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!