Bug 11721 - SN image URLs are rewritten wrong (breaks home menu icons)
: SN image URLs are rewritten wrong (breaks home menu icons)
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: --
: unspecified
: PC Other
: -- normal (vote)
: 7.4.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-08 10:50 UTC by Andy Grundman
Modified: 2009-10-05 14:34 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Grundman 2009-04-08 10:50:15 UTC
SN returns full URLs such as http://www.squeezenetwork.com/static/jive/plugins/Napster/html/images/icon.png.  SP is trying to rewrite them using a bad regex assuming they don't contain a hostname, so they end up like:

/http://www_40x40_o.squeezenetwork.com/static/jive/plugins/Napster/html/images/icon_40x40_o.png

I need to add image resizing support to SN, so I think this should simply be fixed to not clobber the hostname.
Comment 1 Ben Klaas 2009-04-08 11:00:44 UTC
clearly the rewrite regex there must be buggy and will fix that, but SP does not have the ability to resize icons, so delivering an icon in the same resolution to all skins (touch, remote, controller, etc.) is probably not a good option.
Comment 2 Andy Grundman 2009-04-08 11:02:40 UTC
SP does resize them, but doesn't do a very good job.  I need to add it to SN to reduce the file size as well as improve the quality.
Comment 3 Ben Klaas 2009-04-08 11:04:52 UTC
it does? news to me...any time I've received an icon for a menu in the wrong size SP just renders it in that size. You can imagine what a 336x336 icon looks as a menu item thumbnail... 

Maybe some of the skin changes have somewhat remedied that behavior.
Comment 4 Andy Grundman 2009-04-08 11:06:33 UTC
Well look at Rhapsody album covers for example, those have always been resized.
Comment 5 Ben Klaas 2009-04-08 11:18:58 UTC
I'll review this after the MP deadline. I must be mistaken about an underlying mechanism for this. I thought we _were_ sending resize parameters for Rhapsody album covers.
Comment 6 Andy Grundman 2009-04-08 11:20:22 UTC
Nope, there is code to resize them using SDL.  That's why they look terrible. :)
Comment 7 Blackketter Dean 2009-04-08 17:22:03 UTC
As I've said before, SP needs to be able to resize images and icons, and it needs to do it better than it is now.

it's also a reasonable optimization to have the resizing done on the server side, it saves bandwidth, memory on the target device and makes the experience faster.
Comment 8 James Richardson 2009-10-05 14:34:32 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.