Bug 11679 – my music->albums sometimes yields window full of empty buttons

Bug 11679 - my music->albums sometimes yields window full of empty buttons

Summary:

my music->albums sometimes yields window full of empty buttons

Status:	RESOLVED WORKSFORME

Product:	SqueezePlay
Classification:	Unclassified
Component:	Browser
Version:	unspecified
Platform:	PC Other

Importance:	P1 major (vote)
Target Milestone:	7.4.0
Assigned To:	Ben Klaas

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-04-06 12:50 UTC by Ben Klaas
Modified:	2009-09-08 09:15 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
movie of issue being reproduced (6.37 MB, application/octet-stream) 2009-04-06 12:50 UTC, Ben Klaas	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ben Klaas 2009-04-06 12:50:57 UTC

Created attachment 5056 [details]
movie of issue being reproduced

I've seen this a few times. When it's hit it is 100% reproducible, only fixable through a reboot.

Log isn't showing much when entering that window:
Apr  6 14:44:39 SqueezeboxController user.warn jive: (SlimBrowserApplet.lua:353) - Menu:   album
Apr  6 14:44:39 SqueezeboxController user.warn jive: (SlimBrowserApplet.lua:355) - Window: icon_list

exactly the same messages are reported on a Fab4 not exhibiting this behavior, so it appears nothing of use there...

Comment 1 James Richardson 2009-06-09 13:14:38 UTC

This may be addressed in newer firmare, QA to verify

Comment 2 Ben Klaas 2009-06-12 13:40:33 UTC

I reproduced this on desktop today...here's the error that was thrown

20090612 20:26:10.358 WARN   squeezeplay.ui.draw - jiveL_update_screen:594 error in update_screen:
        ...squeezeplay/src/squeezeplay/share/jive/ui/Window.lua:1550: attempt to perform arithmetic on local 'w' (a nil value)
stack traceback:
        ...squeezeplay/src/squeezeplay/share/jive/ui/Window.lua:1550: in function <...squeezeplay/src/squeezeplay/share/jive/ui/Window.lua:1522>
        [C 0x1a7de]: in function 'iterate'
        ...squeezeplay/src/squeezeplay/share/jive/ui/Window.lua:1521: in function '_skinLayout'
        ...squeezeplay/src/squeezeplay/share/jive/ui/Window.lua:1729: 
20090612 20:26:10.405 WARN   squeezeplay.ui.draw - jiveL_update_screen:594 error in update_screen:
        ...squeezeplay/src/squeezeplay/share/jive/ui/Window.lua:1550: attempt to perform arithmetic on local 'w' (a nil value)
stack traceback:
        ...squeezeplay/src/squeezeplay/share/jive/ui/Window.lua:1550: in function <...squeezeplay/src/squeezeplay/share/jive/ui/Window.lua:1522>
        [C 0x1a7de]: in function 'iterate'
        ...squeezeplay/src/squeezeplay/share/jive/ui/Window.lua:1521: in function '_skinLayout'
        ...squeezeplay/src/squeezeplay/share/jive/ui/Window.lua:1729:

Comment 3 Ben Klaas 2009-06-12 13:41:40 UTC

more info: I was doing a fair bit of "shift-R" to reSkin() at the time of seeing this. After being able to reproduce this consistently, another shift-R cleared the issue.

Comment 4 Ben Klaas 2009-06-12 13:46:34 UTC

FYI, line 1550 from Window.lua, borderLayout(), where the error occurred. For whatever reason w is nil when this method is called:

1549                         elseif position == LAYOUT_EAST then
1550                                 w = w + lb + rb or lb + rb
1551                                 w = min(w, sw - lb - rb)
1552

Comment 5 Ben Klaas 2009-08-14 06:48:29 UTC

I haven't seen this in ages, but my guess is it was caused by something being not fully defined correctly in the skin with LAYOUT_EAST.