Bug 1166 - Slimserver 6 doesn't read COMPOSER tag from flac embedded cuesheets
: Slimserver 6 doesn't read COMPOSER tag from flac embedded cuesheets
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Audio
: 6.0.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-22 19:48 UTC by Gordon Harris
Modified: 2008-08-18 10:53 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gordon Harris 2005-03-22 19:48:01 UTC
Slimserver 6 doesn't read COMPOSER tags (or other CD_TEXT keywords like 
ARRANGER, SONGWRITER, etc, other than PERFORMER, GENRE, YEAR and COMMENT) from 
cuesheets embedded in flac files.  In the following cuesheet, the COMPOSER tag 
is ignored for every track:

PERFORMER "Various"
TITLE "Latin American Music for Two Guitars - Sergio and Odair Assad"
GENRE "r_Modern_Latin-American"
YEAR "1985"
FILE "Latin American Music for Two Guitars - Sergio and Odair Assad.flac" WAVE
COMMENT "Sergio and Odair Assad, guitars; Nonesuch 79116-2, 1985"
  TRACK 01 AUDIO
    TITLE "Tango Suite - 1 Deciso"
    PERFORMER "Various"
    COMPOSER "Piazzolla, A"
    GENRE "r_Modern_Latin-American"
    YEAR "1985"
    COMMENT "Astor Piazzolla (b. 1921)"
    INDEX 01 00:00:00
  TRACK 02 AUDIO
    TITLE "��2 Andante"
    PERFORMER "Various"
    COMPOSER "Piazzolla, A"
    GENRE "r_Modern_Latin-American"
    YEAR "1985"
    COMMENT "Astor Piazzolla (b. 1921)"
    INDEX 01 04:22:57
  TRACK 03 AUDIO
    TITLE "��3 Allegro"
    PERFORMER "Various"
    COMPOSER "Piazzolla, A"
    GENRE "r_Modern_Latin-American"
    YEAR "1985"
    COMMENT "Astor Piazzolla (b. 1921)"
    INDEX 01 08:03:52
  TRACK 04 AUDIO
    TITLE "Micro Piezas - 1 Tranquilo"
    PERFORMER "Various"
    COMPOSER "Brouwer, L"
    GENRE "r_Modern_Latin-American"
    YEAR "1985"
    COMMENT "Astor Piazzolla (b. 1921)"
    INDEX 01 14:17:00
  TRACK 05 AUDIO
    TITLE "��2 Allegro Vivace"
    PERFORMER "Various"
    COMPOSER "Brouwer, L"
    GENRE "r_Modern_Latin-American"
    YEAR "1985"
    COMMENT "Leo Brauwer (b. 1939)"
    INDEX 01 15:22:42
  TRACK 06 AUDIO
    TITLE "��3 Vivacissimo muy ritmico"
    PERFORMER "Various"
    COMPOSER "Brouwer, L"
    GENRE "r_Modern_Latin-American"
    YEAR "1985"
    COMMENT "Leo Brauwer (b. 1939)"
    INDEX 01 16:50:42
  TRACK 07 AUDIO
    TITLE "��4 Sonoro"
    PERFORMER "Various"
    COMPOSER "Brouwer, L"
    GENRE "r_Modern_Latin-American"
    YEAR "1985"
    COMMENT "Leo Brauwer (b. 1939)"
    INDEX 01 17:39:42
  TRACK 08 AUDIO
    TITLE "Beb�"
    PERFORMER "Various"
    COMPOSER "Pascoal, H"
    GENRE "r_Modern_Latin-American"
    YEAR "1985"
    COMMENT "Hermeto Pascoal (b. 1936)"
    INDEX 01 19:19:35
  TRACK 09 AUDIO
    TITLE "Retratos - 1 Anacleto de Medeiros"
    PERFORMER "Various"
    COMPOSER "Gnattali, R"
    GENRE "r_Modern_Latin-American"
    YEAR "1985"
    COMMENT "Radam�s Gnattali (b. 1906)"
    INDEX 01 21:31:42
  TRACK 10 AUDIO
    TITLE "��2 Chiquinha Gonzaga"
    PERFORMER "Various"
    COMPOSER "Gnattali, R"
    GENRE "r_Modern_Latin-American"
    YEAR "1985"
    COMMENT "Radam�s Gnattali (b. 1906)"
    INDEX 01 25:08:72
  TRACK 11 AUDIO
    TITLE "Recife Dos Corais"
    PERFORMER "Various"
    COMPOSER "Assad, S"
    GENRE "r_Modern_Latin-American"
    YEAR "1985"
    COMMENT "Sergio Assad (b. 1952)"
    INDEX 01 29:36:47
  TRACK 12 AUDIO
    TITLE "Valseana"
    PERFORMER "Various"
    COMPOSER "Assad, S"
    GENRE "r_Modern_Latin-American"
    YEAR "1985"
    COMMENT "Sergio Assad (b. 1952)"
    INDEX 01 31:40:32
  TRACK 13 AUDIO
    TITLE "Vitoria Regia"
    PERFORMER "Various"
    COMPOSER "Assad, S"
    GENRE "r_Modern_Latin-American"
    YEAR "1985"
    COMMENT "Sergio Assad (b. 1952)"
    INDEX 01 33:10:00
  TRACK 14 AUDIO
    TITLE "Pinote"
    PERFORMER "Various"
    COMPOSER "Assad, S"
    GENRE "r_Modern_Latin-American"
    YEAR "1985"
    COMMENT "Sergio Assad (b. 1952)"
    INDEX 01 35:09:15
  TRACK 15 AUDIO
    TITLE "Idilio Crepuscular"
    PERFORMER "Various"
    COMPOSER "Ginastera, A"
    GENRE "r_Modern_Latin-American"
    YEAR "1980"
    COMMENT "Alberto Ginastera (1916-1983)"
    INDEX 01 37:12:17
Comment 1 Dan Sully 2005-03-22 19:51:24 UTC
Fixed in subversion change 2670.

It will be in tonight's build.
Comment 2 Gordon Harris 2005-03-26 16:22:44 UTC
As of the v6 3/24 nightly, this bug isn't resolved.  If you look 
in /trunk/server/Slim/Formats/FLAC.pm at getCUEinVC, you'll see that only the 
TITLE (album), YEAR, GENRE, COMMENT, TRACK (performer) keywords are parsed.  We 
still aren't parsing COMPOSER, ARRANGER, SONGWRITER, etc.

Comment 3 Dan Sully 2005-03-26 16:31:52 UTC
Sorry about that - you didn't specifiy that the items were in the vorbis
comments, as opposed to a external cue sheet.

I've added COMPOSER, CONDUCTOR and BAND, as that's what we currently support.
Comment 4 Gordon Harris 2005-03-26 16:57:01 UTC
Ummm...isn't that what "embedded cuesheets" means? ;)  Anyway, thanks, and I'm 
sitting here holding my breath waiting for my SB2!
Comment 5 Dan Sully 2005-03-27 11:10:40 UTC
I've added this in the right place now for COMPOSER, CONDUCTOR and BAND.

Can you please file a separate enhancement request for getting SONGWRITER, etc
added?

Thanks.
Comment 6 Gordon Harris 2005-03-27 19:26:47 UTC
I think I'll hold off on that enhancement request until I can find some sort of 
reference that is reasonably definitive in terms of mapping between CD_TEXT, 
CUE and TOC keywords.

In the mean time, the current support for COMPOSER, BAND, CONDUCTOR, etc. is 
plenty for my purposes.

I think I saw a reference somewhere that Slimserver V6 will interpret DISC and 
DISCC tags to help define multi-disc albums.  If so, shouldn't you allow and 
parse those tags in vorbus comments / embeded cuesheets too?  Should that be an 
enhancement request?