Bug 1165 – display ? ? returns HASH...

Bug 1165 - display ? ? returns HASH...

Summary:

display ? ? returns HASH...

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	CLI
Version:	6.0.0
Platform:	Macintosh All

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Blackketter Dean

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-03-22 16:07 UTC by Fred
Modified:	2008-09-15 14:37 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Fred 2005-03-22 16:07:51 UTC

The CLI command "display ? ?" returns HASH(...). The code in Command.pm calls 

my ($line1, $line2) = Slim::Display::Display::curLines($client);

and then this goes into renderOverlay and I am lost since I am no expert in Perl OO code nor in 
graphics displays...

Happens with a SLIMP3 or a SoftSqueeze. Latest SVN.

Comment 1 KDF 2005-03-22 16:46:20 UTC

try this:

--- Slim/Control/Command.pm	2005-03-19 20:49:00.000000000 -0800
+++ server/Slim/Control/Command.pm	2005-03-22 16:38:48.687500000 -0800
@@ -1325,9 +1325,9 @@ sub execute {
 		} elsif ($p0 eq "display") {
 
 			if ($p1 eq "?" && $p2 eq "?") {
-				my ($line1, $line2) = Slim::Display::Display::curLines($client);
-				$p1 = $line1;
-				$p2 = $line2;
+				my $parsed = $client->parseLines(Slim::Display::Display::curLines($client));
+				$p1 = $parsed->{line1} || '';
+				$p2 = $parsed->{line2} || '';
 			} else {
 				Slim::Buttons::ScreenSaver::wakeup($client);
 				$client->showBriefly($p1, $p2, $p3, $p4);

Comment 2 KDF 2005-03-23 00:28:46 UTC

committed to r2685.  please reopen if these results are not satisfactory.

Comment 3 Chris Owens 2006-06-16 14:41:08 UTC

There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.