Bug 1155 - Server rescan having more trouble with Ogg tags
: Server rescan having more trouble with Ogg tags
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Database
: 6.0.0
: PC Linux (other)
: P2 minor (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-22 07:48 UTC by Steve Bernard
Modified: 2008-09-15 14:37 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Bernard 2005-03-22 07:48:45 UTC
I'm running svn version 2651of the server, and tons of my tracks are being piled
into No Album/No Artist that actually do have valid Ogg Vorbis tags.  I'm wiping
and rescanning over and over, and a lot of the same tracks keep coming up in No
Album.  I looked at --d_info and I have a lot of lines that look like this:

2005-03-22 10:10:04.3983 reading tags for:
file:///mnt/audio/albums/As%20Upon%20the%20Road%20Thereto/01-Langtry-Billy%20Bowlegs%20Blues.ogg
Ogg::Vorbis::Header::PurePerl: Didn't find an ogg header - invalid file?
Use of uninitialized value in numeric eq (==) at
/opt/slimserver/Slim/Formats/Ogg.pm line 53.
2005-03-22 10:10:04.4090 Info: no title found, using plain title for
file:///mnt/audio/albums/As%20Upon%20the%20Road%20Thereto/01-Langtry-Billy%20Bowlegs%20Blues.ogg

This particular file has perfectly fine tags, far as I can see, and is up at
http://loungent.dyndns.org/temp/

Late last week, the server was in a state where I had to wipe about three times
for stuff like this not to show up in No Album/No Artist, but I was dealing with
it.  As of last night I'm getting it consistently every time.

I can post more log if you want, or send a db file.

As it is with this version, I can't get the DB to build all of my album lists
correctly.
Comment 1 Dan Sully 2005-03-22 08:42:42 UTC
Steve - can you change line 357 in CPAN/Ogg/Vorbis/Header/PurePerl.pm from:

my $len = $data->{'INFO'}{'blocksize_0'};

to:

my $len = $data->{'INFO'}{'blocksize_0'} * 2;

and wipe your database?
Comment 2 Steve Bernard 2005-03-22 09:26:27 UTC
Adding that '* 2' did work for everything but, and bear with me here, Ogg Vorbis
tracks that consist entirely of silence.  I have a handful of tracks here and
there that are like ten seconds or twenty two seconds of silence, because that's
how the tracks appear on the original album.  Now they're shoved into No
Album/No Artist, depite having valid tags.  I moved one to
http://loungent.dyndns.org/temp/ if you want to have a look.  Perhaps it's not
the content but just the file size?
Comment 3 Dan Sully 2005-03-22 14:14:54 UTC
Steve - I've checked in a fix as of Subversion change 2653 that will work with
both files.
Comment 4 Chris Owens 2006-06-16 14:41:59 UTC
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.
Comment 5 Steve Bernard 2006-06-17 19:48:23 UTC
Oh, I never actually set this to closed.  That's my fault, since this was fixed forever ago.