Bugzilla – Bug 11463
Incomplete support for JSON::XS v1 and v2
Last modified: 2011-03-16 04:39:08 UTC
Created attachment 4969 [details] Patch to move to JSON::XS::VersionOneAndTwo everywhere I produce the Gentoo package and Gentoo only includes the v2 JSON::XS package; I believe SqueezeCenter internally bundles the v1 package. Most places in the SqueezeCenter source use JSON::XS::VersionOneAndTwo as this allows both v1 and v2 versions of the CPAN module JSON::XS too be used without worrying about the change of API between them. However, there are three places remaining where JSON::XS is imported directly rather than through VersionOneAndTwo, which means those modules fail on Gentoo (http://bugs.gentoo.org/show_bug.cgi?id=263416). I believe those places are safe to move to VersionOneAndTwo, and that's the patch I'm including in the Gentoo package. Attached is that patch - if that could be incorporated in the core SqueezeCenter it would fix this problem for everyone, I think.
Andy to review and implement
Since there's now a planned 7.3.3 release, bugs which won't make the cut-off are being moved to the next target out. If you feel that this bug needs to be addressed more (or less) urgently than the 7.4 release, please cc chris@slimdevices.com and leave a comment in the bug to that effect so we can review it. Thanks.
For some reason Bugzilla did not change the target when I did this yesterday. Or maybe it was me. In either case, I'm trying it again.
Fixed in change 26976.
Yes, I can confirm those changes in the latest 7.4 trunk svn. I'd close this or mark it as verified but I'm not sure that's the current etiquette. Thanks Andy.
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server! * SqueezeCenter: 28672 * Squeezebox 2 and 3: 130 * Transporter: 80 * Receiver: 65 * Boom: 50 * Controller: 7790 * Radio: 7790 Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.