Bugzilla – Bug 11430
cosmetic: keyboard tweaks
Last modified: 2010-02-18 13:01:18 UTC
Created attachment 4955 [details] Keyboard skinning for rounded corners this ain't workin' yet, so attaching patch so as not to lose work in progress
Created attachment 4961 [details] current IP keyboard
Created attachment 4962 [details] current lowercase qwerty keyboard
Created attachment 4963 [details] current numeric keyboard
Created attachment 4964 [details] keyboard with light colored wallpaper. highlights edge issues There are still some rendering problems at the edges, where it appears darker. Noah asserts this may be due to two assets with transparency layering on top of each other. That doesn't appear how the skin is configured, however.
r4916 takes us most of the way there for the keyboard, including pressed assets. still need: confirm with Noah that pressed behavior is as intended with each key figure out problem with "dark" edge assets extend titlebar to go beyond and below textinput (will require some fakery to do this, as the textinput will not actually be part of the titlebar)
Created attachment 4965 [details] Top edge test artwork (transparent box)
Changing summary to use this bug as the catch-all for remaining issues with keyboard window layout. Remaining issues: 1. pressed tile assets for keys along top and bottom rows incorrect (except for top left and bottom left corners). Problem resides with these two assets: Buttons/keybrd_n_button_press_t.png Buttons/keybrd_s_button_press_b.png working this issue with Noah 2. vertical spacing between keyboard <--> textinput and keyboard <--> bottom of window needs to be the same 3. need to create visual effect that titlebar + textinput are all part of the titlebar.
Additional cosmetic issues to resolve: 1. Cursor height should be 26px high and NOT extend into text entry window border 2. The top buttons (back, ?), text entry field, and keyboard should share the same right/left edge alignment. For example the left vertical edge of the back button, left edge. Current build r4940 text entry window and keyboard aligned, but not aligned to titlebar buttons (left/right). 3. Keyboard key font sizes are not correct main keys: QWERTY/1234.../@#$ - FS Bold 24px bottom row keys: (any text grouping whether numeric or alpha) 123-&/ABC, done, search, .com - FS Bold 20px (any individual characters/symbols) @, ., _, etc. - FS Bold 24px 4. "Done" button should have added emphasis, propose quick fix of inc. contrast RGB 231,231,231. 5. Delete button appears misaligned top/bottom. Could move up ~1px. 6. Shift icon should move down ~1px to appear centered top/bottom 7. There is no way to get to addition symbols. Need to add jump button to lower, left corner (above ABC). Enhancements: 8. Cursor should blink on/off every sec. Currently artwork is static. 9. Press and hold on delete button should clear all. 10. Back button in titlebar currently goes back one character at a time. Back button should always be back to previous menu.
r4948 has smaller font sizes for the "special" keys, space bar, done, and keyboard switcher buttons. I also changed the font color for the done button to 231, 231, 231, while the others are 220, 220, 220. To my eyes, it's imperceptible, so there may be additional work there.
issues #1 and #3 from comment#7 are fixed, r5023
Looking this over, I think we're good for MP. Remaining cosmetic tweaks to Keyboard: 1. pressed assets are still not right, but they are definitely good enough for MP 2. done button should have a spinny when input is submitted but hasn't pushed to a new window (separate bug open for that) 3. cosmetic tweaks to textinput cursor
changing several bugs at once-- target milestone on these do not apply to the CXR/CAT milestone
There may not be anything to do on this bug any more, but keeping open for audit and retargetting for 7.5
Ben, Does this include everything from comment #8? 11. I am still seeing funky alignment along the top row and corners when pressed. 12. There is also a drop shadow or nested text for "done." The net effect is that it appears blurry. Need to remove the drop shadow. 13. The titlebar bkgrd and bkgrd asset for the text input window are different alphas (darker). If possible, should reuse asset from titlebar to prevent future discrepancies.
Okay, work to do then. Sorry, it's been a while since I've considered this... estimating 4 hours because the keyboard is esp. tricky for layout issues
== Auto-comment from SVN commit #7972 to the jive repo by bklaas == == https://svn.slimdevices.com/jive?view=revision&revision=7972 == Bug: 11430 Description: unblur the done button on the keyboard
What's left in this bug is not a P1. The most glaring needs-fixing is some 1px aberrations on pressed state for some of the keyboard keys. But, seeing as these aberrations are typically under a finger...moving to P3
This is going to be a WONTFIX