Bug 11389 - Brightness Menu can not be adjusted with IR remote
: Brightness Menu can not be adjusted with IR remote
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Settings
: unspecified
: PC Windows Vista
: P1 normal (vote)
: 7.4.0
Assigned To: Felix Mueller
:
Depends on:
Blocks: 13564
  Show dependency treegraph
 
Reported: 2009-03-18 14:13 UTC by Osama Zaidan
Modified: 2009-10-05 14:30 UTC (History)
6 users (show)

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Osama Zaidan 2009-03-18 14:13:17 UTC
From the Home menu, going to Setting->Screen->Brightness I saw three issues that bothered me; 

1) I can not adjust the Brightness using the left/right arrow key on the remote control, however I can I adjust it  manually from the touch screen. 

2) The message in that menu says, “Use the wheel to adjust the Brightness”, this a FAB4 not SB Boom.

3) There is tiny clock showing in black just below the bar (for adjusting brightness) line, is the time supposed to show in this menu? 

Firmware = r4833
Comment 1 Felix Mueller 2009-03-27 14:55:28 UTC
In r4993 the brightness menu is completely broken. There is no way to change brightness as the slider is missing. I only see the 'Use the wheel to adjust the brightness.' text.
Comment 2 Jim McAtee 2009-04-01 20:14:18 UTC
In r5058 selecting Settings > Screen > Brightness kicks you back out to the Home menu.
Comment 3 KDF 2009-06-15 21:05:13 UTC
r6098 Brightness control gives only the "automatic brightness" option, which cannot be turned off once selected.
Comment 4 Blackketter Dean 2009-06-15 23:32:34 UTC
Can you take a look at this, Raphael?
Comment 5 Raphael Juchli 2009-06-17 05:03:04 UTC
(In reply to comment #4)
> Can you take a look at this, Raphael?

Sure, I'll have a look at it.
I guess we need a "manual brightness" setting back in the menu so the users don't have to go back to the brightness slider and "touch" it to go back to manual mode.
Comment 6 Raphael Juchli 2009-06-17 12:04:32 UTC
I've added a manual brightess setting back in in the Brightness Control menu.

However I noticed some strange behavior:
SqueezeBoxFab4Applet:init(..) gets called when you enter one of the brightness submenus in the Screen Menu.
So you end up with multiple brightness timers running.

I haven't figured out why this is happening yet. I didn't see anything obvious in SqueezeboxFab4Applet itself. Maybe someone else has some insight?
Comment 7 Blackketter Dean 2009-06-17 17:18:11 UTC
Right, the idea here is that there's a checkbox (not a radio button) that turns on and off Automatic Brightness.  

If you view the slider, you see the current brightness position, if you drag to change it, it turns off the automatic checkbox and moves you to manual.  

In order to go back to Automatic, you need to go back and check the box again.

Both this checkbox and the Brightness sub-menu should appear directly in the screen menu.

(And this should work on all products with ambient light detectors. :)
Comment 8 Blackketter Dean 2009-06-17 17:18:58 UTC
Ben/Tom: any idea about Raphael's last comment?
Comment 9 Raphael Juchli 2009-06-18 11:49:55 UTC
I also might need some help on how to get a checkbox directly in the screen menu. I tried to create my own menu item table (based on the AppletMeta:menuItem code) with the normal "check = Checkbox(...)" I used in other menus but was unsucessful so far. 
My Item was displayed but without a checkbox.
Comment 10 Blackketter Dean 2009-07-22 09:02:03 UTC
Moving to the product SqueezePlay because this bug appears to apply to any player based on that application code.  Feel free to move it back if it's specific to the original product.
Comment 11 James Richardson 2009-08-19 11:10:45 UTC
is this bug valid still? 

Seems to work for me on SP based devices using latest firmware r7069
Comment 12 James Richardson 2009-08-19 11:13:02 UTC
Marking as fixed, please reopen if you feel this was done in error.
Comment 13 Jim McAtee 2009-08-19 11:21:09 UTC
Here's what I still see on Fab4 at r7096:  This is roughly the same as the original bug description, point #1.  In the manual brightness adjustment I can find no way to adjust the brightness (i.e. move the slider) using the IR remote.

- Left arrow behaves correctly and does a BACK.
- Right arrow is broken and also does a BACK.  It should probably bump.
- Up/Down arrow, which I would expect to move the slider, do nothing.
Comment 14 Jim McAtee 2009-08-19 11:49:57 UTC
If you ask a question, you need to give folks more than 5 minutes to respond before closing a bug.
Comment 15 James Richardson 2009-08-19 12:01:46 UTC
I forgot to test via IR.  Thank you for validating this.

Felix: would this be yours to look at?
Comment 16 Jim McAtee 2009-08-19 12:14:13 UTC
Here are a couple other things I see with the IR if I use an old IR remote with a 'Brightness' button:

1. If you use the Brightness button, the Fab4 pops into the Brightness adjustment screen.  But if you hit the button while in this screen then the screens stack up.

2. Sometimes when you hit the Brightness button it first goes into a screen with a gray (not green) slider and no 3D shading, then it quickly moves into the more familiar looking screen with colored slider and shading.  It's as though there are two versions of the screen.
Comment 17 Felix Mueller 2009-08-19 12:24:33 UTC
James: Sure, I can take a look at this. I might need some help from Tom though.
Comment 18 SVN Bot 2009-08-21 11:04:52 UTC
 == Auto-comment from SVN commit #7209 to the jive repo by felix ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7209 ==

Bug: 11389 
Description: Support IR in brightness menu
Comment 19 SVN Bot 2009-08-21 11:07:24 UTC
 == Auto-comment from SVN commit #7210 to the jive repo by felix ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7210 ==

Bug: 11389 
Description: Support IR in brightness menu
Comment 20 Felix Mueller 2009-08-21 11:12:30 UTC
Fixed in r7270.

Note: Brightness button on old remotes does nothing. Fab4 and Baby remotes do not have this button. Please open an enhancement request if you feel strongly about that.
Comment 21 Felix Mueller 2009-08-21 11:13:39 UTC
I meant: fixed in r7210
Comment 22 Jim McAtee 2009-08-21 14:25:21 UTC
(In reply to comment #20)

> Note: Brightness button on old remotes does nothing.

At r7210 the Brightness button still pushes into the Brightness adjustment screen and they still stack up if you press it more than once.
Comment 23 James Richardson 2009-08-21 14:36:51 UTC
Using the SB3 remote on my IR capable SP devices, all I get is bumped
Comment 24 Felix Mueller 2009-08-21 15:04:17 UTC
You are both right. ;)

It seems when the player is connected to SN pressing the brightness button indeed goes to the brightness screen.

However if one breaks out of setup all the brightness button is doing is bumping.

I guess I need to fix the stacking then.
Comment 25 Jim McAtee 2009-08-21 15:20:10 UTC
No, I'm definitely not connected to SN when I see this.
Comment 26 SVN Bot 2009-09-02 09:20:56 UTC
 == Auto-comment from SVN commit #7375 to the jive repo by felix ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7375 ==

Bug: 11389 +1 
Description: Fixed stacking up screens if brightness is pressed more than once.
Comment 27 James Richardson 2009-10-05 14:30:06 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.