Bug 11351 – Undefined 'machine' in Jive.pm line 2306

Bug 11351 - Undefined 'machine' in Jive.pm line 2306

Summary:

Undefined 'machine' in Jive.pm line 2306

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Misc
Version:	7.4.0
Platform:	PC Other

Importance:	-- normal (vote)
Target Milestone:	---
Assigned To:	Unassigned bug - please assign me!

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-03-14 00:11 UTC by KDF
Modified:	2009-03-14 03:33 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description KDF 2009-03-14 00:11:47 UTC

the log message:

Use of uninitialized value in string eq at /usr/local/slimserver/svn/7.4/trunk/server/Slim/Control/Jive.pm line 2306.

both $request->getParam('machine') and $self->getParam('_machine') are 'undef'

this is 7.4 at r25533.  seems to come up when there is no new firmware for controller  

Two options: force a default using || 'jive' on both, or check that getParam('machine') is defined before doing the eq test.

Comment 1 Adrian Smith 2009-03-14 03:33:32 UTC

change 25534

I missed that when debugging the controller update - this occurs for old controller images which don't set the machine name.