Bugzilla – Bug 1124
'Now playing (jump back on wake)' does not change with song title change
Last modified: 2011-03-16 04:19:52 UTC
Problem: Now playing screen does not change when the song title changes at teh end of each song. How to recreate: Start playing a album from the player interface. Do not press any more keys after that. Allow the 'now playing jump back on wake' screensaver to kick in. How to fix: use the 'now playing' screensaver without the 'jump back on wake' Other info: (dont know if this matters for recreation), default1 webui is loaded, mandrake 10, sbg1, only notices when I upgraded to slimserver 6 over the last week or so, slimserver 6 nightly 18.3.5
song changes all go through Playlist::jump, but we only kill animation for playlist mode. we need to do this for screensaver mode as well, so use showingNowPlaying to be correct. patch shortly.
Created attachment 349 [details] reset animation when showingNowPlaying instead of just playlist mode this will update the song animation for modes other than just "now playing" screensaver.
Looks good.
committed r2600
still seems broken to me - sorry!
I can't reproduce, so I'm off this one. I have tested with with sb2, ss 2.0a14 and SBG
John, did you try this with the latest nightly release?
21/3 release, linux, sb1, now palying (jump back on wake)
Actually it is working if I just add, for example, a whole album to the playlist. However if I create a musicmagic playlist, and then press play when it shows... Musicmagic mix (1 of x) song title ...the screensaver never actually kicks in and the results of the musicmagic mix stay on the screen Obviously this list does not change when the next track starts. So it is a problem with the musicmagic mix screen not allowing the screensaver to activate? Need any more info? Cheers
the problem is becuase the musicmagic_mix list is likely scrolling. there are several problems with scrolling, including a total lack of ability to break out of it unless its specifically killed. The screensaver waits until animation stops by some other method, since an animating screen is essentially fulfilling the reuiqrement of screen saving.
Created attachment 363 [details] go into screensaver regardless of animation this patch removes animation as a way to prevent the screensaver from kicking in. instead, only start $client->scrollBottom if we're not already animating
committed a patch r2686. please test this and confirm that the musicmagic mix is no longer holding off the screensaver.
well, that doesnt' work. $client->animation use is broken. it is supposed to be for client animations, yet it still flags scrollbottom. thus, as long as there is scrolling, there is no screensaver.
vidur, I leave this up to you to sort out.
Passing it along to Dean, since he made the original change and has more of the graphics stuff in his head than I do.
Created attachment 370 [details] add $client->scrolling param ok, this attempts to set a scrolling param that will allow us to break outof scrollbottom or other slow scrolling.
*** This bug has been marked as a duplicate of 1151 ***