Bugzilla – Bug 11226
Can't drill into track details anymore (SBC) after upgrade 25192 -> 25242
Last modified: 2009-06-17 09:37:07 UTC
After upgrading SC from svn 25192 to 25242, it's not possible to drill down into the track details from the Controller, neither from the Music Library nor from the Now Playing screen. server.log: [09-03-01 17:54:04.3876] Slim::Control::Request::execute (1889) Error: While trying to run function coderef [Slim::Menu::TrackInfo::cliQuery]: [Can't store CODE items at ..\..\lib\Storable.pm (autosplit into ..\..\lib\auto\Storable\_freeze.al) line 339, at D:\Projekte\SqueezeCenter\7.4\server\CPAN/DBIx/Class/Serialize/Storable.pm line 10 ] [09-03-01 18:02:16.4545] Slim::Control::Request::execute (1889) Error: While trying to run function coderef [Slim::Menu::TrackInfo::cliQuery]: [Can't store CODE items at ..\..\lib\Storable.pm (autosplit into ..\..\lib\auto\Storable\_freeze.al) line 339, at D:\Projekte\SqueezeCenter\7.4\server\CPAN/DBIx/Class/Serialize/Storable.pm line 10 ]
Reverting back to r25192 immediately cured this problem, so it must have somthing to do with the latest changes.
Tried 7.4-25385 today. Still the same! Console shows: [09-03-07 18:53:32.1207] Slim::Control::Request::execute (1889) Error: While trying to run function coderef [Slim::Menu::TrackInfo::cliQuery]: [Can't store CODE items at ..\..\lib\Storable.pm (autosplit into ..\..\lib\auto\Storable\_freeze.al) line 339, at D:\Projekte\SqueezeCenter\7.4\server\CPAN/DBIx/Class/Serialize/Storable.pm line 10] Controller spins the "right arrow" right next to the track name endlessly (until aborted by pressing LEFT).
This is due to change 25220 for 7.3 ad change 25221 for 7.4. It involves the session-based caching through XMLBrowser. cc'ing andy as this was his change.
Doh, thanks for the heads up.
Andy, would it make sense to simply wrap it in an eval with a log message when the data to be cached isn't valid for storable? Index: Slim/Control/XMLBrowser.pm =================================================================== --- Slim/Control/XMLBrowser.pm (revision 25400) +++ Slim/Control/XMLBrowser.pm (working copy) @@ -242,7 +242,11 @@ # Cache the feed structure for this session $log->is_debug && $log->debug( "Caching session $sid" ); - $cache->set( "xmlbrowser_$sid", $feed, CACHE_TIME ); + eval { $cache->set( "xmlbrowser_$sid", $feed, CACHE_TIME ) }; + + if ( $@) { + $log->warn("Session not cached: [$@"]); + } } if ( my $levels = scalar @index ) {
Created attachment 4899 [details] eval wrapper and warning when session caching fails. patch for the above, with a corrected typo.
Yep, can confirm the problem: SC 7.4r25403 on Linux, with SBC 7.4r4719, player-UI works. Log: [09-03-08 11:39:59.9155] Slim::Control::Request::execute (1889) Error: While trying to run function coderef [Slim::Menu::TrackInfo::cliQuery]: [Can't store CODE items at blib/lib/Storable.pm (autosplit into blib/lib/auto/Storable/_freeze.al) line 339, at /opt/SqueezeCenter_svn/7.4/trunk/server/CPAN/DBIx/Class/Serialize/Storable.pm line 10 + kdf's patch fixes this. kind regards, Markus
If you press enter while viewing the "Now Playing" screen on the SBC, in order to look at your playlist or whatever, you will be stuck with this problem. You will be able to go back through the menu structure to the left but not to the right. You have to go all the way back to the home page to make it work again.
Applied kdf's patch, and also for web XMLBrowser, in change 25411.
Cheers KDF, Markus, Andy for checking and a fix on a weekend! Much appreciated. Confirm fixed in SC7.4-25416 for Windows.
verified fix in SC 7.3.3 r25948
This bug has been fixed in the 7.3.3 release version of SqueezeCenter! If you haven't already. please download the new version from http://www.logitechsqueezebox.com/support/download-squeezecenter.html If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.