Bug 11223 - Patch flac to allow infinite streams
: Patch flac to allow infinite streams
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Transcoding
: 7.3.3
: All All
: -- normal (vote)
: 7.3.3
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-03-01 01:08 UTC by Alan Young
Modified: 2009-06-17 09:37 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments
Patch as an attachement to make it easier to apply. (483 bytes, patch)
2009-03-01 03:15 UTC, Adrian Smith
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Young 2009-03-01 01:08:40 UTC
If flac were rebuilt with the following patch from triode, then this would enable it to be used for transcoding radio streams and the like. At the moment it will stop after a little more than 3 hours.

2008-12-23 11:40:28.000000000 +0000
+++ encode.c    2009-03-01 00:22:16.000000000 +0000
@@ -1061,7 +1061,10 @@
                                                       
print_error_with_state(&encoder_session, "ERROR during encoding");
                                                        return
EncoderSession_finish_error(&encoder_session);
                                                }
-                                               data_bytes -= bytes_read;
+
+                                               if
(!options.common.ignore_chunk_sizes) {
+                                                       data_bytes -=
bytes_read;
+                                               }
                                        }

Please patch the flac build and supply new versions for all platforms.
Comment 1 Adrian Smith 2009-03-01 03:15:35 UTC
Created attachment 4877 [details]
Patch as an attachement to make it easier to apply.

Note we need to use the --ignore-chunk-sizes option to make this patch work
Comment 2 Andy Grundman 2009-03-01 07:55:01 UTC
Let's pass this upstream, too.
Comment 3 Adrian Smith 2009-03-16 11:43:52 UTC
I think this should be included in 7.3.3 as otherwise the faad streaming will timeout after 6 hours (probably long enough), but lets fix it as we know how...
Comment 4 Andy Grundman 2009-03-16 11:51:39 UTC
Agreed.  I will do it.
Comment 5 Andy Grundman 2009-03-17 15:11:47 UTC
Builds in change 25591.
Comment 6 James Richardson 2009-04-29 07:52:55 UTC
Verified fixed in
SqueezeCenter 7.3.3 r26228

Played ALAC stream for >20 hours
Comment 7 James Richardson 2009-06-17 09:37:06 UTC
This bug has been fixed in the 7.3.3 release version of SqueezeCenter!

If you haven't already. please download the new version from http://www.logitechsqueezebox.com/support/download-squeezecenter.html 

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.