Bug 11205 - Customize Controller; wallpaper image displays blank if not formatted properly
: Customize Controller; wallpaper image displays blank if not formatted properly
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Plugin
: 7.3.0
: PC Windows XP
: P1 normal (vote)
: 7.4.0
Assigned To: Adrian Smith
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-26 11:55 UTC by James Richardson
Modified: 2009-10-05 14:27 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Richardson 2009-02-26 11:55:44 UTC
Customize Controller wallpaper image will display a 'blank' image on the target device if the image is not in the proper image size for that device.

Customize Controller should either a) warn the user or b) resize the image for the target device
Comment 1 Chris Owens 2009-03-30 17:32:32 UTC
Since there's now a planned 7.3.3 release, bugs which won't make the cut-off are being moved to the next target out.  If you feel that this bug needs to be addressed more (or less) urgently than the 7.4 release, please cc chris@slimdevices.com and leave a comment in the bug to that effect so we can review it.

Thanks.
Comment 2 Chris Owens 2009-03-31 08:55:00 UTC
For some reason Bugzilla did not change the target when I did this yesterday.  Or maybe it was me.  In either case, I'm trying it again.
Comment 3 Adrian Smith 2009-08-05 06:22:13 UTC
Fixed in change 28066
Comment 4 Andy Grundman 2009-08-05 06:48:11 UTC
 == Automatic comment from SVN commit #28068 to Repository: slim ==
https://svn.slimdevices.com/slim?view=revision&revision=28068

 r57521@macbookpro (orig r28060):  andy | 2009-08-04 20:54:59 -0400
 Fixes for max mode, appears to work properly in all cases now
 r57522@macbookpro (orig r28061):  andy | 2009-08-04 22:37:23 -0400
 A little image resizer test suite, stopped at max because I think it's still not right
 r57523@macbookpro (orig r28062):  michael | 2009-08-05 03:03:57 -0400
 Fixed Bug: 12937
 Description: remove documentation for removed feature
 r57524@macbookpro (orig r28063):  michael | 2009-08-05 03:09:07 -0400
 Fixed Bug: 13197
 Description: document --logdir in slimserver.pl
 r57525@macbookpro (orig r28064):  adrian | 2009-08-05 04:50:13 -0400
 Bug: 13017
 Description: update description of Extension Downloader as it now replaces the plugin page and is really part of the core server
 
 r57526@macbookpro (orig r28065):  michael | 2009-08-05 05:17:35 -0400
 Bug: n/a
 Description: partly revert string removal
 r57527@macbookpro (orig r28066):  adrian | 2009-08-05 09:21:29 -0400
 Bug: 11205
 Description: Check the size of wallpaper images added via JiveExtras and only serve the correct size to the controller.  Show an error message on the web interface if the size is wrong.
 
 r57528@macbookpro (orig r28067):  adrian | 2009-08-05 09:25:06 -0400
 Bug: N/A
 Description: change 28066 requires this too
 



 == Modified 10 files total ==
7.4/private-branches/baby-cat/
7.4/private-branches/baby-cat/server/HTML/EN/html/docs/cli-api.html
7.4/private-branches/baby-cat/server/Slim/Plugin/Extensions/install.xml
7.4/private-branches/baby-cat/server/Slim/Plugin/Extensions/strings.txt
7.4/private-branches/baby-cat/server/Slim/Plugin/JiveExtras/HTML/EN/plugins/JiveExtras/settings/basic.html
7.4/private-branches/baby-cat/server/Slim/Plugin/JiveExtras/Plugin.pm
7.4/private-branches/baby-cat/server/Slim/Plugin/JiveExtras/Settings.pm
7.4/private-branches/baby-cat/server/Slim/Plugin/JiveExtras/strings.txt
7.4/private-branches/baby-cat/server/Slim/Utils/ImageResizer.pm
7.4/private-branches/baby-cat/server/slimserver.pl

 == Added 14 files total ==
7.4/private-branches/baby-cat/tests/data/images/
7.4/private-branches/baby-cat/tests/data/images/ref/
7.4/private-branches/baby-cat/tests/data/images/ref/square-cover-100x50-112233.jpg
7.4/private-branches/baby-cat/tests/data/images/ref/square-cover-50x100.png
7.4/private-branches/baby-cat/tests/data/images/ref/square-cover-50x50.jpg
7.4/private-branches/baby-cat/tests/data/images/ref/square-icon-100x100.png
7.4/private-branches/baby-cat/tests/data/images/ref/tall-cover-100x100.png
7.4/private-branches/baby-cat/tests/data/images/ref/wide-cover-100x100.png
7.4/private-branches/baby-cat/tests/data/images/source/
7.4/private-branches/baby-cat/tests/data/images/source/square-cover.jpg
7.4/private-branches/baby-cat/tests/data/images/source/square-icon.png
7.4/private-branches/baby-cat/tests/data/images/source/tall-cover.jpg
7.4/private-branches/baby-cat/tests/data/images/source/wide-cover.jpg
7.4/private-branches/baby-cat/tests/t/05resizer.t
Comment 5 Andy Grundman 2009-08-05 06:48:49 UTC
 == Automatic comment from SVN commit #28069 to Repository: slim ==
https://svn.slimdevices.com/slim?view=revision&revision=28069

 r57521@macbookpro (orig r28060):  andy | 2009-08-04 20:54:59 -0400
 Fixes for max mode, appears to work properly in all cases now
 r57522@macbookpro (orig r28061):  andy | 2009-08-04 22:37:23 -0400
 A little image resizer test suite, stopped at max because I think it's still not right
 r57523@macbookpro (orig r28062):  michael | 2009-08-05 03:03:57 -0400
 Fixed Bug: 12937
 Description: remove documentation for removed feature
 r57524@macbookpro (orig r28063):  michael | 2009-08-05 03:09:07 -0400
 Fixed Bug: 13197
 Description: document --logdir in slimserver.pl
 r57525@macbookpro (orig r28064):  adrian | 2009-08-05 04:50:13 -0400
 Bug: 13017
 Description: update description of Extension Downloader as it now replaces the plugin page and is really part of the core server
 
 r57526@macbookpro (orig r28065):  michael | 2009-08-05 05:17:35 -0400
 Bug: n/a
 Description: partly revert string removal
 r57527@macbookpro (orig r28066):  adrian | 2009-08-05 09:21:29 -0400
 Bug: 11205
 Description: Check the size of wallpaper images added via JiveExtras and only serve the correct size to the controller.  Show an error message on the web interface if the size is wrong.
 
 r57528@macbookpro (orig r28067):  adrian | 2009-08-05 09:25:06 -0400
 Bug: N/A
 Description: change 28066 requires this too
 



 == Modified 10 files total ==
7.4/branches/noweb/
7.4/branches/noweb/server/HTML/EN/html/docs/cli-api.html
7.4/branches/noweb/server/Slim/Plugin/Extensions/install.xml
7.4/branches/noweb/server/Slim/Plugin/Extensions/strings.txt
7.4/branches/noweb/server/Slim/Plugin/JiveExtras/HTML/EN/plugins/JiveExtras/settings/basic.html
7.4/branches/noweb/server/Slim/Plugin/JiveExtras/Plugin.pm
7.4/branches/noweb/server/Slim/Plugin/JiveExtras/Settings.pm
7.4/branches/noweb/server/Slim/Plugin/JiveExtras/strings.txt
7.4/branches/noweb/server/Slim/Utils/ImageResizer.pm
7.4/branches/noweb/server/slimserver.pl

 == Added 14 files total ==
7.4/branches/noweb/tests/data/images/
7.4/branches/noweb/tests/data/images/ref/
7.4/branches/noweb/tests/data/images/ref/square-cover-100x50-112233.jpg
7.4/branches/noweb/tests/data/images/ref/square-cover-50x100.png
7.4/branches/noweb/tests/data/images/ref/square-cover-50x50.jpg
7.4/branches/noweb/tests/data/images/ref/square-icon-100x100.png
7.4/branches/noweb/tests/data/images/ref/tall-cover-100x100.png
7.4/branches/noweb/tests/data/images/ref/wide-cover-100x100.png
7.4/branches/noweb/tests/data/images/source/
7.4/branches/noweb/tests/data/images/source/square-cover.jpg
7.4/branches/noweb/tests/data/images/source/square-icon.png
7.4/branches/noweb/tests/data/images/source/tall-cover.jpg
7.4/branches/noweb/tests/data/images/source/wide-cover.jpg
7.4/branches/noweb/tests/t/05resizer.t
Comment 6 Andy Grundman 2009-08-05 06:49:24 UTC
 == Automatic comment from SVN commit #28070 to Repository: slim ==
https://svn.slimdevices.com/slim?view=revision&revision=28070

 r57536@macbookpro (orig r28069):  andy | 2009-08-05 09:48:46 -0400
  r57521@macbookpro (orig r28060):  andy | 2009-08-04 20:54:59 -0400
  Fixes for max mode, appears to work properly in all cases now
  r57522@macbookpro (orig r28061):  andy | 2009-08-04 22:37:23 -0400
  A little image resizer test suite, stopped at max because I think it's still not right
  r57523@macbookpro (orig r28062):  michael | 2009-08-05 03:03:57 -0400
  Fixed Bug: 12937
  Description: remove documentation for removed feature
  r57524@macbookpro (orig r28063):  michael | 2009-08-05 03:09:07 -0400
  Fixed Bug: 13197
  Description: document --logdir in slimserver.pl
  r57525@macbookpro (orig r28064):  adrian | 2009-08-05 04:50:13 -0400
  Bug: 13017
  Description: update description of Extension Downloader as it now replaces the plugin page and is really part of the core server
  
  r57526@macbookpro (orig r28065):  michael | 2009-08-05 05:17:35 -0400
  Bug: n/a
  Description: partly revert string removal
  r57527@macbookpro (orig r28066):  adrian | 2009-08-05 09:21:29 -0400
  Bug: 11205
  Description: Check the size of wallpaper images added via JiveExtras and only serve the correct size to the controller.  Show an error message on the web interface if the size is wrong.
  
  r57528@macbookpro (orig r28067):  adrian | 2009-08-05 09:25:06 -0400
  Bug: N/A
  Description: change 28066 requires this too
  
 



 == Modified 10 files total ==
7.4/branches/noweb-sqlite/
7.4/branches/noweb-sqlite/server/HTML/EN/html/docs/cli-api.html
7.4/branches/noweb-sqlite/server/Slim/Plugin/Extensions/install.xml
7.4/branches/noweb-sqlite/server/Slim/Plugin/Extensions/strings.txt
7.4/branches/noweb-sqlite/server/Slim/Plugin/JiveExtras/HTML/EN/plugins/JiveExtras/settings/basic.html
7.4/branches/noweb-sqlite/server/Slim/Plugin/JiveExtras/Plugin.pm
7.4/branches/noweb-sqlite/server/Slim/Plugin/JiveExtras/Settings.pm
7.4/branches/noweb-sqlite/server/Slim/Plugin/JiveExtras/strings.txt
7.4/branches/noweb-sqlite/server/Slim/Utils/ImageResizer.pm
7.4/branches/noweb-sqlite/server/slimserver.pl

 == Added 14 files total ==
7.4/branches/noweb-sqlite/tests/data/images/
7.4/branches/noweb-sqlite/tests/data/images/ref/
7.4/branches/noweb-sqlite/tests/data/images/ref/square-cover-100x50-112233.jpg
7.4/branches/noweb-sqlite/tests/data/images/ref/square-cover-50x100.png
7.4/branches/noweb-sqlite/tests/data/images/ref/square-cover-50x50.jpg
7.4/branches/noweb-sqlite/tests/data/images/ref/square-icon-100x100.png
7.4/branches/noweb-sqlite/tests/data/images/ref/tall-cover-100x100.png
7.4/branches/noweb-sqlite/tests/data/images/ref/wide-cover-100x100.png
7.4/branches/noweb-sqlite/tests/data/images/source/
7.4/branches/noweb-sqlite/tests/data/images/source/square-cover.jpg
7.4/branches/noweb-sqlite/tests/data/images/source/square-icon.png
7.4/branches/noweb-sqlite/tests/data/images/source/tall-cover.jpg
7.4/branches/noweb-sqlite/tests/data/images/source/wide-cover.jpg
7.4/branches/noweb-sqlite/tests/t/05resizer.t
Comment 7 Andy Grundman 2009-08-05 06:49:58 UTC
 == Automatic comment from SVN commit #28071 to Repository: slim ==
https://svn.slimdevices.com/slim?view=revision&revision=28071

 r57521@macbookpro (orig r28060):  andy | 2009-08-04 20:54:59 -0400
 Fixes for max mode, appears to work properly in all cases now
 r57522@macbookpro (orig r28061):  andy | 2009-08-04 22:37:23 -0400
 A little image resizer test suite, stopped at max because I think it's still not right
 r57523@macbookpro (orig r28062):  michael | 2009-08-05 03:03:57 -0400
 Fixed Bug: 12937
 Description: remove documentation for removed feature
 r57524@macbookpro (orig r28063):  michael | 2009-08-05 03:09:07 -0400
 Fixed Bug: 13197
 Description: document --logdir in slimserver.pl
 r57525@macbookpro (orig r28064):  adrian | 2009-08-05 04:50:13 -0400
 Bug: 13017
 Description: update description of Extension Downloader as it now replaces the plugin page and is really part of the core server
 
 r57526@macbookpro (orig r28065):  michael | 2009-08-05 05:17:35 -0400
 Bug: n/a
 Description: partly revert string removal
 r57527@macbookpro (orig r28066):  adrian | 2009-08-05 09:21:29 -0400
 Bug: 11205
 Description: Check the size of wallpaper images added via JiveExtras and only serve the correct size to the controller.  Show an error message on the web interface if the size is wrong.
 
 r57528@macbookpro (orig r28067):  adrian | 2009-08-05 09:25:06 -0400
 Bug: N/A
 Description: change 28066 requires this too
 



 == Modified 10 files total ==
7.4/private-branches/fab4/
7.4/private-branches/fab4/server/HTML/EN/html/docs/cli-api.html
7.4/private-branches/fab4/server/Slim/Plugin/Extensions/install.xml
7.4/private-branches/fab4/server/Slim/Plugin/Extensions/strings.txt
7.4/private-branches/fab4/server/Slim/Plugin/JiveExtras/HTML/EN/plugins/JiveExtras/settings/basic.html
7.4/private-branches/fab4/server/Slim/Plugin/JiveExtras/Plugin.pm
7.4/private-branches/fab4/server/Slim/Plugin/JiveExtras/Settings.pm
7.4/private-branches/fab4/server/Slim/Plugin/JiveExtras/strings.txt
7.4/private-branches/fab4/server/Slim/Utils/ImageResizer.pm
7.4/private-branches/fab4/server/slimserver.pl

 == Added 14 files total ==
7.4/private-branches/fab4/tests/data/images/
7.4/private-branches/fab4/tests/data/images/ref/
7.4/private-branches/fab4/tests/data/images/ref/square-cover-100x50-112233.jpg
7.4/private-branches/fab4/tests/data/images/ref/square-cover-50x100.png
7.4/private-branches/fab4/tests/data/images/ref/square-cover-50x50.jpg
7.4/private-branches/fab4/tests/data/images/ref/square-icon-100x100.png
7.4/private-branches/fab4/tests/data/images/ref/tall-cover-100x100.png
7.4/private-branches/fab4/tests/data/images/ref/wide-cover-100x100.png
7.4/private-branches/fab4/tests/data/images/source/
7.4/private-branches/fab4/tests/data/images/source/square-cover.jpg
7.4/private-branches/fab4/tests/data/images/source/square-icon.png
7.4/private-branches/fab4/tests/data/images/source/tall-cover.jpg
7.4/private-branches/fab4/tests/data/images/source/wide-cover.jpg
7.4/private-branches/fab4/tests/t/05resizer.t
Comment 8 James Richardson 2009-10-05 14:27:53 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.