Bug 11126 - Time is not displayed in Now Playing screen
: Time is not displayed in Now Playing screen
Status: CLOSED FIXED
Product: MySqueezebox.com
Classification: Unclassified
Component: Player UI
: Prod
: PC Other
: -- normal (vote)
: Hotfix
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-19 03:46 UTC by Michael Herger
Modified: 2009-05-06 07:08 UTC (History)
0 users

See Also:
Category: ---


Attachments
migrate prefs on SN instead of hard-coding a conversion list (3.24 KB, patch)
2009-02-19 06:05 UTC, Michael Herger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Herger 2009-02-19 03:46:41 UTC
In Genesis we added an option to display the current time of day as a now playing option. We missed one change in the slimservice code - the time is not displayed (anybody ever tested this?).
Comment 1 Michael Herger 2009-02-19 03:48:42 UTC
change 25080 should fix this issue.

Andy - I'm not familiar with that block of code. Please review and roll out if you're ok with it. Thanks!
Comment 2 mooblie 2009-02-19 05:17:48 UTC
As far as I can see - SN control webpage Players:Display:Now Playing Info: Options include "Show Buffer Fullness" and "Clock" at the end of the list of options.

These last two options do not appear when you try and access the Display: Now Playing Info: Options on the SB2 front panel+remote.

And - even if selected on the SN control webpage: they don't work?  HTH.
Comment 3 Michael Herger 2009-02-19 05:23:59 UTC
Oh, ok, there's more to this issue than just that it doesn't work. We lack these options from the player menu too.
Comment 4 Michael Herger 2009-02-19 06:05:34 UTC
Created attachment 4835 [details]
migrate prefs on SN instead of hard-coding a conversion list

Andy - The code I changed earlier this morning only fixes one occurence, but not eg. the player menu. We should get rid of that "fix" and migrate the prefs instead. Maybe we could even unconditionally change them, as imho there's no way on SN to change that list anyway.
Comment 5 Michael Herger 2009-02-20 06:27:28 UTC
change 25098 - adding Clock to the player's settings.
Comment 6 mooblie 2009-02-21 06:31:32 UTC
Nearly there - but:
(a) player's "Now Playing Info" menu options still do not match SN player settings control webpage - i.e. "Clock" is not there, but not "Buffer Fullness", 
and 
(b) selecting "Clock" on player menu gives "Buffer Fullness" display! 
...so the only way to get a "Clock" display is to use SN control webpage - but that then works!
Comment 7 mooblie 2009-02-21 06:33:52 UTC
(In reply to comment #6) - Sorry - I mistyped above comment, ignore that and read this one:

> Nearly there - but:
> (a) player's "Now Playing Info" menu options still do not match SN player
> settings control webpage - i.e. "Clock" IS there now, but not "Buffer
> Fullness", 
> and 
> (b) selecting "Clock" on player menu gives "Buffer Fullness" display! 
> ...so the only way to get a "Clock" display is to use SN control webpage - but
> that then works!
Comment 8 Michael Herger 2009-02-23 09:04:02 UTC
change 25133 - need to fix the option's ID number.

I'm sorry Andy, this would need another rollout...
Comment 9 mooblie 2009-03-04 04:54:46 UTC
Many thanks for fixing this, guys (and gals, maybe?)

A massive increase in Squeezenetwork usability if you ask me.  I only ever use "Clock" display now.  Thanks again.
Comment 10 James Richardson 2009-05-06 07:08:22 UTC
This bug has been fixed in the latest release of SqueezeNetwork!

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.