Bug 11056 - Vorbis Comment "DESCRIPTION" frame should be mapped to "COMMENT"
: Vorbis Comment "DESCRIPTION" frame should be mapped to "COMMENT"
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Formats
: 7.4.0
: All All
: -- normal with 2 votes (vote)
: 7.3.3
Assigned To: James Richardson
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-12 04:26 UTC by Moonbase
Modified: 2009-06-17 09:36 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Proposed patch for FLAC and OGG, could be retrofitted into 7.3.3 (1.03 KB, patch)
2009-03-17 13:44 UTC, Moonbase
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Moonbase 2009-02-12 04:26:20 UTC
Since many people (and software) use the Vorbis Comment tag frame "DESCRIPTION" instead of "COMMENT" *and* it is in the Xiph "proposed, minimal list of standard field names", we should map the "DESCRIPTION" into "COMMENTS", at least in FLAC.pm and Ogg.pm.

See forum:
http://forums.slimdevices.com/showthread.php?t=59980

See Xiph.org:
http://xiph.org/vorbis/doc/v-comment.html
Comment 1 Chris Owens 2009-03-02 09:19:52 UTC
Andy plans to review this and try to support it.  He thinks the behavior will be that 'COMMENT' will be used if it's there, otherwise 'DESCRIPTION'
Comment 2 Moonbase 2009-03-06 00:57:27 UTC
Sounds feasible. Many use COMMENT nowadays (Mp3tag, Picard), but there are still apps out there that use the more "official" DESCRIPTION frame.
Comment 3 Chris Owens 2009-03-16 09:51:25 UTC
We are now planning to make a 7.3.3 release.  Please review your bugs (all marked open against 7.3.3) to see if they can be fixed in the next few weeks, or if they should be retargeted for 7.4 or future.

Thanks!
Comment 4 Moonbase 2009-03-17 13:44:16 UTC
Created attachment 4941 [details]
Proposed patch for FLAC and OGG, could be retrofitted into 7.3.3

Proposed patch to Server/Slim/Formats/FLAC.pm and Ogg.pm to include DESCRIPTION.
Comment 5 Andy Grundman 2009-03-18 08:09:53 UTC
Patch applied in 7.3.3 change 25609.
Comment 6 James Richardson 2009-04-30 08:04:26 UTC
Moonbase: can you verified that the fix is in SqueezeCenter 7.3.3 r26228 (or later)
Comment 7 Moonbase 2009-05-09 00:33:23 UTC
Just verified against current (svn) versions:

SC 7.3-26509: Yes
SC 7.4-26509: Yes
Comment 8 James Richardson 2009-06-17 09:36:55 UTC
This bug has been fixed in the 7.3.3 release version of SqueezeCenter!

If you haven't already. please download the new version from http://www.logitechsqueezebox.com/support/download-squeezecenter.html 

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.