Bug 11000 - Error messages on top line don't work that well
: Error messages on top line don't work that well
Status: RESOLVED WONTFIX
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 7.3.2
: PC Other
: P3 normal (vote)
: 8.0.0
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-07 15:52 UTC by Andy Grundman
Modified: 2012-03-09 06:45 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Grundman 2009-02-07 15:52:01 UTC
Some errors are too long for Boom (and even SB3), and since the top line doesn't scroll I think we need to move the errors back to the second line.  Or make the top line scrollable.
Comment 1 Adrian Smith 2009-02-07 16:10:07 UTC
The display code will scroll any line, but scrolling of the top line is disabled as too many modes caused it to scroll when it was not desired.

If you want to try it just remove the check for $l == 0:

--- Slim/Display/Graphics.pm    (revision 24920)
+++ Slim/Display/Graphics.pm    (working copy)
@@ -385,7 +385,7 @@
                                        $sc->{scrolline} = undef;
                                }
 
-                       } elsif (!$scroll || $l == 0 || ($sc->{scroll} && $sc->{scrollline} != $l) || ($s2periodic && $screen1) ) {
+                       } elsif (!$scroll || ($sc->{scroll} && $sc->{scrollline} != $l) || ($s2periodic && $screen1) ) {
                                # scrolling not enabled, line 0 or already scrolling for another line - truncate line
                                if (!$sc->{linereverse}[$l]) {
                                        $bits |= substr($sc->{linebits}[$l], 0, $sc->{overlaystart}[$l]). $sc->{overlaybits}[$l];

To scroll the top line in preference to other lines reverse the order of the for loop above this (scrolling more than one line at once is not supported)
Comment 2 Michael Herger 2009-07-27 07:47:30 UTC
Andy - what example message would cause this issue?
Comment 3 Michael Herger 2009-07-30 01:13:52 UTC
Punting 7.4 bugs to 8.0
Comment 4 Chris Owens 2009-10-12 09:31:32 UTC
Adrian, andy notes that we don't want to enable scrolling of the top line anywhere.
Comment 5 Adrian Smith 2009-10-12 11:24:52 UTC
I agree - if we scroll the top line there would be many places to fix to avoid it scrolling all the time (the reason its disabled, but wanted to point out the code handles it should we want to..)

I think the best solution is to move the problem error messages to the bottom line.  This needs a per error message fix though - i.e. the place creating the showBriefly needs its code updated to use the lower line.