Bugzilla – Bug 10935
Binary artwork shown in scanner.log (FLAC, _preCheckAttributes), making the system BEEP all the time
Last modified: 2009-02-03 01:12:46 UTC
SC7.4-24847/Windows (Perl version) Slim::Schema::_preCheckAttributes is displaying binary content of ARTWORK into the log. When debug is on, this leads to awful bios PC speaker beeping (if using the Perl version from a commandline) -- and unneccessary delay. Log view is also messed up by that: When viewing the log in a browser, it often suddenly suggests downloading scanner.log (instead of just displaying it). I suggest disabling ARTWORK output (it will also unneccessarily create HUGE log files if debug is on).
Index: Schema.pm =================================================================== --- Schema.pm (revision 24845) +++ Schema.pm (working copy) @@ -1998,7 +1998,12 @@ while (my ($tag, $value) = each %{$attributes}) { - $log->debug(".. $tag : $value") if defined $value; + # Bug 10935 - Also need to avoid artwork dump here (see below) + if ($tag eq 'ARTWORK') { + $log->debug(".. $tag : [Binary Image Data]") if defined $value; + } else { + $log->debug(".. $tag : $value") if defined $value; + } } $log->debug("* Deferred Attributes *");
change 24850