Bug 10900 - Crossfade tries to work with different sample rates
: Crossfade tries to work with different sample rates
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Audio
: unspecified
: PC Other
: P1 major (vote)
: 7.4.0
Assigned To: Richard Titmuss
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-30 04:13 UTC by Alan Young
Modified: 2009-10-05 14:29 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Young 2009-01-30 04:13:55 UTC
Crossfade will still try to work when the outgoing and incoming tracks have different sample rates. This is different to ip3k, so it screws up sync, and it sounds weird.
Comment 1 Chris Owens 2009-03-16 09:51:02 UTC
We are now planning to make a 7.3.3 release.  Please review your bugs (all marked open against 7.3.3) to see if they can be fixed in the next few weeks, or if they should be retargeted for 7.4 or future.

Thanks!
Comment 2 Chris Owens 2009-03-30 17:34:30 UTC
Since there's now a planned 7.3.3 release, bugs which won't make the cut-off are being moved to the next target out.  If you feel that this bug needs to be addressed more (or less) urgently than the 7.4 release, please cc chris@slimdevices.com and leave a comment in the bug to that effect so we can review it.

Thanks.
Comment 3 Richard Titmuss 2009-08-05 04:08:14 UTC
 == Automatic comment from SVN commit #6914 to Repository: jive ==
https://svn.slimdevices.com/jive?view=revision&revision=6914

Fixed Bug #10900
Worktime: 30

Fixed so crossfade won't work when the outgoing and incoming tracks have different sample rates. This needs to be fixed differently 
from ip3k, as the squeezeplay software does not perform it's own resampling.




 == Modified 1 files total ==
7.4/private-branches/fab4/squeezeplay/src/squeezeplay/src/audio/decode/decode_output.c
Comment 4 Richard Titmuss 2009-08-05 04:08:47 UTC
Correct hours!
Comment 5 Alan Young 2009-08-15 00:14:53 UTC
Does this mean that ip3k does actually do some sort of crossfade in this case by SP not?
Comment 6 Richard Titmuss 2009-08-15 00:36:02 UTC
No, on ip3k the sample rate conversion code prevents tracks with different samples rates being written into the output buffer. So this also prevents the crossfade. We don't have sample rate conversion in SP (it's done in alsa), so this code needs to work differently.
Comment 7 James Richardson 2009-10-05 14:29:39 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.