Bug 10808 - Line out setting not followed for during an alarm
: Line out setting not followed for during an alarm
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Alarm
: 7.3.0
: All All
: -- normal (vote)
: 7.3.3
Assigned To: James Richardson
http://forums.slimdevices.com/showthr...
:
Depends on:
Blocks: 8146
  Show dependency treegraph
 
Reported: 2009-01-23 12:58 UTC by Gary Morgan
Modified: 2009-06-17 09:36 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gary Morgan 2009-01-23 12:58:46 UTC
Have line out set to always on. Powers a second set of speakers in the ensuite. Works fine except when the boom fires up from the alarm. 

External speaker seems to be off. If I check the audio setting it still shows line out always. If I set this to off and back on during an alarm the external speakers start working?
Comment 1 James Richardson 2009-01-26 09:00:54 UTC
Max: don't we turn line-out off during an alarm event?  I remember a bug about it, but couldn't find it.
Comment 2 Max Spicer 2009-01-26 11:31:21 UTC
We set line-out mode to subwoofer during an alarm if something is plugged into line out.  This is done in order to force output through the main speakers on the assumption that headphones are plugged in.  See bug 8146.

The case of people plugging speakers into the headphone socket wasn't really considered.  There's also the additional problem in that during an alarm with headphones plugged in, sub-woofer mode is used, causing the main speakers to lack bass.  In summary, this bug should probably be resolved invalid, but there may be another two bugs lurking round the corner.  A lot of these details are in bug 8146.
Comment 3 Gary Morgan 2009-01-26 13:01:47 UTC
OK that explains why I am actually hearing a very quite muffled sound out if the ensuite speaker as it lacks in the base department.

As to the logic I would say the safest setting is Line Out = On that way both outputs are active during an alarm. That is unless you want a alarm specific  output selection.
Comment 4 Max Spicer 2009-01-26 13:26:47 UTC
Bug 8146 was really closed too early.  Enabling sub mode was the only way at the time of making sound come through the main speakers even though something was plugged into line out.  I don't know if it is yet possible to choose in software to have the same output through the main speakers and line out.  Is this what Line Out->Always On does?

Felix - can you help?  If there's now a software setting to do this, I'll change the alarm code.
Comment 5 Felix Mueller 2009-01-26 14:31:24 UTC
Hi Max, yes, you should be able to change that from SC and yes, it's the always on option. I believe this can be set from within the player settings page.

/*
 * Mode == 0 -> headphone
 * Mode == 1 -> sub out
 * Mode == 2 -> always on
 * Mode == 3 -> always off
 */
Comment 6 James Richardson 2009-02-05 10:34:14 UTC
Max: should I change this to a SC bug?
Comment 7 Max Spicer 2009-02-05 11:02:47 UTC
Change 24893 should fix this.  Line out mode is now temporarily set to always on during an alarm, rather than subwoofer.  This should force sound to always play through the internal speakers during an alarm.  If something is plugged into line out, that should play too.  The problem case now is if someone actually has a sub plugged into line out...

Could you test please, James?
Comment 8 Gary Morgan 2009-02-05 11:31:26 UTC
This would mean the sub gets a full range signal which will sound different but should not be the end of the world as its own roll off should mix OK. But should the logic be:

If client has selected "Always on" or "Subwoofer" then set the output to "Always on" or "Subwoofer" as appropriate.

If the client has selected "Always off" or "Headphones" the set "Always on"

Comment 9 Max Spicer 2009-02-05 11:38:03 UTC
Gary: good point!  I'll add that tomorrow if I get a chance.
Comment 10 James Richardson 2009-02-05 13:24:47 UTC
(In reply to comment #8)
> 
> If the client has selected "Always off" or "Headphones" the set "Always on"
> 

Did you mean "...then set to 'Always OFF'  That would make more sense to me
Comment 11 Gary Morgan 2009-02-05 14:18:54 UTC
I'm not sure of the exact operation of each of the settings. But I assumed that becasue the exsisting code tried to force a situation to make sure an output was active that the logic should follow a simalar route.

I guess the only issue is when it is set for headphones so maybe the test should be against that only. I leave it you guys to figure. 


But still first time I have been involved with bug reporting and it is great to see it all working. Keep up the good work!
Comment 12 Max Spicer 2009-02-06 14:24:36 UTC
Change 24919 changes things so that the line out mode is only changed during an alarm if the line out pref is set to headphones.  In this case, line out mode is temporarily set to 'always on', which will force output through the main speakers as well as the headphones.  This will ensure that someone asleep with headphones in will get woken up, as well as anyone else in the room.  People using subs or external speakers won't be affected.  Testing needed, but we should be done.
Comment 13 Gary Morgan 2009-02-08 23:29:52 UTC
Latest build installed and seems to be working fine from my perspective. So thanks guys! Keep up the good work.
Comment 14 Anoop Mehta 2009-04-16 16:14:12 UTC
Verified fixed in SC 7.3.3 r25948
Comment 15 James Richardson 2009-06-17 09:36:31 UTC
This bug has been fixed in the 7.3.3 release version of SqueezeCenter!

If you haven't already. please download the new version from http://www.logitechsqueezebox.com/support/download-squeezecenter.html 

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.