Bug 10772 - Previous / next on extras / news browser articles does not jump to beginning of article
: Previous / next on extras / news browser articles does not jump to beginning ...
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Applet
: unspecified
: All Windows XP
: -- minor (vote)
: 7.4.0
Assigned To: Adrian Smith
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-20 06:58 UTC by Stéphane Guillard
Modified: 2009-10-05 14:36 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillard 2009-01-20 06:58:14 UTC
Hello,

Subject says it all : open a news article from any news server in extras/news, scroll down a bit using wheel, go to next article using top right wheel key (or prev using top left wheel key), the new article is shown already scrolled down rather than always jumping back to beginning, which is how it should be.

Regards,
-- 
Stéphane
Comment 1 Chris Owens 2009-03-16 09:50:37 UTC
We are now planning to make a 7.3.3 release.  Please review your bugs (all marked open against 7.3.3) to see if they can be fixed in the next few weeks, or if they should be retargeted for 7.4 or future.

Thanks!
Comment 2 James Richardson 2009-03-26 15:07:10 UTC
Please re-test with 7.3.3, as we have not been able to verify this yet.
Comment 3 Chris Owens 2009-03-30 17:20:04 UTC
Since there's now a planned 7.3.3 release, bugs which won't make the cut-off are being moved to the next target out.  If you feel that this bug needs to be addressed more (or less) urgently than the 7.4 release, please cc chris@slimdevices.com and leave a comment in the bug to that effect so we can review it.

Thanks.
Comment 4 James Richardson 2009-05-11 14:00:48 UTC
Triode: the News Browser appears to be missing on SqueezeOS products now, can you have a look at this one?
Comment 5 Ben Klaas 2009-05-11 14:05:49 UTC
I'd have to guess that the root of the problem is InfoBrowser being added/removed dynamically when connected to a player. I just booted a 7.4 controller fresh and Extras->InfoBrowser was there and worked fine. I have definitely seen it disappear of late though, and I think it's probably after connecting to other players. So far I have not been able to reproduce though...
Comment 6 Stéphane Guillard 2009-05-12 07:56:48 UTC
Hi,

There are actually 2 bugs with respect to the news browser (and this bug log has drifted from one to the other) :

1 - the original bug that I posted here is :
  o you reach a news item which won't fit in a page, and scroll down through it using the wheel, 
  o you stay at the bottom of said news item,
  o you press "right arrow" to move to the next news item, which happens to also not fit in a single page
  -> the 2nd news item is shown "already scrolled down", ie you don't see the top lines

2 - more often than not, the news browser will disappear from the "Extras" menu. The only way I've found to make it come back is to reboot the controller.

I am currently running the latest public version, which is 7.3.2 iirc, and can attest that both issues are present in this version.

Regards,
-- 
Stéphane
Comment 7 Adrian Smith 2009-05-13 14:12:27 UTC
Problem 1 - Ben - do you know if there is an api call to scroll up to the top of the text area?

Problem 2 - I think this is a problem with dynamically adding menu entries as players are attached and detached.  Can we try to reproduce this as I can't do it at present (as per Ben)
Comment 8 Ben Klaas 2009-05-15 13:20:01 UTC
there is no api call for scrolling to the top of a textarea, but that seems like incorrect behavior. When re-entering a window with a textarea it should always start at the top. My feeling is that this should be fixed in the textarea widget.

Richard, can you comment?
Comment 9 Adrian Smith 2009-05-15 13:30:01 UTC
So in this case I change the content of the textarea widget with setValue.

I think this should probably also reset the internal state associated with scolling so it shows the top of the textarea?
Comment 10 Ben Klaas 2009-05-15 13:40:50 UTC
sorry, didn't understand how it was being called there. If the textarea is being replaced with setValue I think it should go to the top, but that might be debatable. The other option would be to create textarea:goToTop() method, which may be doable in just Lua.
Comment 11 Adrian Smith 2009-05-15 13:50:25 UTC
so if we don't change the default behaviour I can probably call _scrollTo(0) but it would be nicer to have a public method to do that or have it happen by default
Comment 12 James Richardson 2009-06-30 05:49:27 UTC
Adrian: any update on this?
Comment 13 Adrian Smith 2009-07-18 06:25:09 UTC
Resetting to the top of the textarea will be fixed in 7.4 once available (change 6661)
Comment 14 Blackketter Dean 2009-07-22 08:40:02 UTC
Moving to the product SqueezePlay because this bug appears to apply to any player based on that application code.  Feel free to move it back if it's specific to the single original product.
Comment 15 Adrian Smith 2009-07-23 13:37:51 UTC
Marking as fixed as it is addressed in 6661 but this won't be able to be tested until 7.4 is released.
Comment 16 James Richardson 2009-10-05 14:36:03 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.