Bugzilla – Bug 10744
International characters sorted wrong when browsing Music Folder
Last modified: 2010-12-10 02:38:54 UTC
When browsing the Music Folder in the web UI in SC, on the Controller (FW 7.3 r3698), SB3 (FW 122) and Boom (FW 42) the "Swedish" characters ÅÄÖåäö are not sorted correctly, i.e. they do not come last in the list. I am running SC 7.3.2 - 24612 @ Sat Jan 10 03:02:29 PST 2009, Operativsystem: Windows XP - SV - cp1252, Plattformsarkitektur: 586, Perl-version: 5.8.8 - MSWin32-x86-multi-thread, MySQL-version: 5.0.22-community-nt. The language in SC and on the players is set to Swedish (Svenska). I have tried switching languages back and forth as suggested in Bug# 10114. SC is running on Swedish Win XP and the Music Folder is also on a PC running Swedish Win XP.
Just to be sure: they are displayed correctly, but in the wrong order. And this happens in Browse Music Folder only?
(In reply to comment #1) > Just to be sure: they are displayed correctly, but in the wrong order. And this > happens in Browse Music Folder only? The answer is yes to both your questions. The characters (ÅÄÖåäö) all display fine as well as files and folders containing the characters, but the folders are not sorted correctly (I assume it is the same for files, but I do not know for sure since all my music files are prefixed with numbers). A switch between languages as per Bug# 10114 fixed the sorting in the other SC and Controller browsing pages, but not when browsing the Music Folder.
Michael: would this be yours to fix? if not, reassign
vagskal - do you have perl installed on your machine and can run SC from the source? If so - could you please try the following change? Index: /Users/mh/Documents/workspace/7.3/server/Slim/Music/Info.pm =================================================================== --- /Users/mh/Documents/workspace/7.3/server/Slim/Music/Info.pm (revision 24732) +++ /Users/mh/Documents/workspace/7.3/server/Slim/Music/Info.pm (working copy) @@ -900,6 +900,9 @@ } sub sortFilename { + + use locale; + # build the sort index # File sorting should look like ls -l, Windows Explorer, or Finder - # really, we shouldn't be doing any of this, but we'll ignore If not, I can provide you with a custom build of squeezecenter.exe
Created attachment 4687 [details] Patched executable to support localized sort in Browse Music Folder Please give this a try: - shut down SC - locate squeezecenter.exe on your disk and rename it (backup) - put the attached version in its place - restart SC does this change the sort order?
(In reply to comment #5) > Created an attachment (id=4687) [details] > Patched executable to support localized sort in Browse Music Folder > > Please give this a try: > > - shut down SC > - locate squeezecenter.exe on your disk and rename it (backup) > - put the attached version in its place > - restart SC > > does this change the sort order? Thanks for the executable (I am afraid that the perl thing suggested went a bit above my head). I did as you suggested, but the sort order did not change.
Ok, my previous attempt obviously failed, because it didn't address the real issue.
Created attachment 4691 [details] new build removing our file name normalization We were using kind of normalization when sorting, which meant ö -> o etc. This version doesn't do this any more, but relies on the system's locale instead. I tested this on a Swedish Windows and it's looking promising: a Exempelmusik o p Plalylists ä ö
(In reply to comment #8) > Created an attachment (id=4691) [details] > new build removing our file name normalization > > We were using kind of normalization when sorting, which meant ö -> o etc. This > version doesn't do this any more, but relies on the system's locale instead. I > tested this on a Swedish Windows and it's looking promising: > > a > Exempelmusik > o > p > Plalylists > ä > ö This one worked for me. Thanks! When will this fix be included in a SC 7.3.3 nightly?
change 24748 - use system's locale to do the sorting instead of "normalizing" filenames our way. This change will be in tomorrow's (25th) build.
(In reply to comment #10) > change 24748 - use system's locale to do the sorting instead of "normalizing" > filenames our way. > > This change will be in tomorrow's (25th) build. Thanks!
marking as verified. Please re open if problem re occurs.
This bug has been fixed in the 7.3.3 release version of SqueezeCenter! If you haven't already. please download the new version from http://www.logitechsqueezebox.com/support/download-squeezecenter.html If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
After upgrading to 7.5.1 I tried browsing the music folder and the sort order is wrong again; same issue as before. (BUT for the first time in a very long time the sort order in the artist list is correct after a version update, without having to switch language back and forth. Well done!)
what interface are you using? Do you see the same on all interfaces (Web, classic, squeezeplay)?
It is the same in the web UI and on the controller (and in iPeng). I have not checked on the SB3.
Just checked: It is the same also on the SB3.
The original problem was fixed in 7.3.3. It appears that the problem has reoccurred and that is covered by bug 14906. Closing this bug.